Repository navigation
🐞 Changes to the color scheme are not applied in real-time #990
Description
Description
When we are changing the color scheme for a particular type of text, it does not change until we switch to another theme and switch it back.
To Reproduce
- Open
CodeEdit - Open a file with syntax highlighting
- Go to
Settings,Themes - Change the color scheme of a type of text (e.g.
Keywords) - Go back to the editor, the color doesn’t change
- Change to another theme
- Change back the theme
- The changed color is now applied
2023-01-17_10-12-22.mp4
Expected behavior
When we change the color scheme, it should instantly apply.
Version information
CodeEdit: 78bf33e
macOS: 13.1 (22C65)
Xcode: 14.1 (14B47b)
Additional context
N/A
Metadata
Metadata
Assignees
Labels
Type
Projects
- Status
Activity
austincondiff commentedon Jan 18, 2023
Nice find! Color values should really be updating in real-time as the user changes them so they can get instant feedback.
[-]🐞 The color scheme changes don't apply instantly[/-][+]🐞 Changes to the color scheme or font are not applied in real-time[/+]Qubik65536 commentedon Jan 18, 2023
I was looking at these problems, and from what I can tell, there's just no function taking charge of the color scheme changes, so, the changes on the theme won't be applied to
selectedThemevariable, so the only way to apply the changes has to change the theme and change it back (as the color value is applied, but theselectedThemeshould be reloaded).ben-p-commits commentedon Jan 18, 2023
@Cubik65536- font updates are being handled in a PR that just merged into CodeEditTextView:
CodeEditApp/CodeEditTextView#122
You're right about the live color scheme changes needing some additional love to address..
ben-p-commits commentedon Jan 18, 2023
@Cubik65536 - can you modify the scope of this issue to remove the concern about fonts, to keep things tidy / separate?
Qubik65536 commentedon Jan 18, 2023
I will do it later
[-]🐞 Changes to the color scheme or font are not applied in real-time[/-][+]🐞 Changes to the color scheme are not applied in real-time[/+]Qubik65536 commentedon Jan 18, 2023
I did the modification and removed the concern about fonts.
ben-p-commits commentedon Jan 24, 2023
@austincondiff - this rhymes with some of the stuff I did around line wrapping / misc text editor prefs. would be happy to nab this one.
austincondiff commentedon Feb 16, 2023
@ben-p-commits what is the status of this one?
austincondiff commentedon Apr 19, 2025
This works now, closing.
Screen.Recording.2025-04-18.at.11.33.25.PM.mov