Skip to content

chore(storage): drop resetStorageMethod, whose last caller was a removed quarantined suite - #8956

Merged
waleedlatif1 merged 1 commit into
stagingfrom
chore/drop-dead-reset-storage-method
Oct 13, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
chore/drop-dead-reset-storage-method

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

#8953 deleted the quarantined github-member.integration.ts, which was the only caller of resetStorageMethod (a "testing only" export in lib/core/storage). check:unused-exports now fails checks / lint on staging and on every open PR:

✗ 2 new unused export(s):
  apps/sim/lib/core/storage/index.ts:6 resetStorageMethod
  apps/sim/lib/core/storage/storage.ts:78 resetStorageMethod

This deletes the function, its barrel re-export, and the no-op key in idempotency/service.test.ts's vi.mock factory. Nothing else references it.

Test plan

  • checks / lint (check:unused-exports) green
  • idempotency/service.test.ts passes

@vercel

vercel Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 13, 2026 3:07am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Low impact] This cleanup appears safe to merge.

Summary

Removes the unused, test-only resetStorageMethod function.

  • Tests can no longer reset the cached storage choice through the storage module.

Reviews (1) · Last reviewed commit: "chore(storage): drop resetStorageMethod,..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit 9375c01 into staging Oct 13, 2026
40 checks passed
@waleedlatif1
waleedlatif1 deleted the chore/drop-dead-reset-storage-method branch October 13, 2026 03:13

This branch was previously deployed

1 inactive deployment
Preview — 2cc8dcfd Deployed Oct 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant