Skip to content

chore(tests): remove the seven quarantined integration suites - #8953

Merged
waleedlatif1 merged 1 commit into
stagingfrom
chore/remove-quarantined-integration
Oct 13, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
chore/remove-quarantined-integration

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

Seven integration suites have been excluded in apps/sim/vitest.config.ts since 2026-09-25. They fail against a freshly provisioned database because their fixtures predate connector and credential changes, so they never run in CI. They gave no coverage and added maintenance and a false sense of safety.

  • Delete the 7 suites (organization personal tokens; Confluence enrollment; excluded-member documents; GitHub, Gmail, Google Calendar and Jira member sync) and the quarantine block. exclude is back to the live-test rule only.
  • Remove the code that became dead: getCredentialGroupOAuthContext in enrollments.ts, which only the GitHub suite called, and its @sim/testing mock entries. Also remove 6 check-explicit-any baseline entries for the deleted files.
  • sim-testing.md (and its .mdc mirror): fix or delete a failing suite, never exclude it.

Coverage note. These suites never ran, so effective coverage doesn't change, but the behaviors they were written for are still untested. The highest-risk one, withdrawing a member's documents when the provider reports lost access (GitHub 403/404, Jira 400, Calendar 404), is being covered by a new real-Postgres integration test in a follow-up PR. The full list, with what still covers each behavior, is in the PR thread below.

Test plan

  • CI integration shards (8) green with the shorter exclude list
  • check:audits (explicit-any baseline, test-patterns)

The seven suites excluded from the integration run since 2026-09-25 failed against a
freshly provisioned database (fixtures predate connector and credential changes) and never
ran in CI. Delete them, the quarantine list in vitest.config.ts, their explicit-any baseline
entries, and getCredentialGroupOAuthContext (plus its @sim/testing mock), whose only caller
was the GitHub member suite. The testing rule now says to fix or delete a failing suite
rather than exclude it.
@vercel

vercel Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 13, 2026 3:06am UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

These behaviors were asserted only by the deleted suites. None of them ever ran in CI.

  1. Access withdrawal in member sync (member-sync-engine.ts ~:1451): when the provider reports lost access (GitHub 403/404, Jira 400, Calendar 404), the sync withdraws the member's documents. Only the connectors' error classification is unit-tested. A real-Postgres test is coming in a follow-up PR.
  2. Purge timing: suspended members are no longer checked for removal after the 30-day cutoff, and tombstoned documents are no longer checked for actual deletion after the 7-day window.
  3. Excluded documents: member sync over an excluded document is untested, and so is withdrawing access to one (it should become unrestorable).
  4. Jira: narrowed fields should re-index even when the issue's update time hasn't changed, and losing project access partway through listing should drop documents seen on earlier pages.
  5. GitHub: an uninstalled repo should index nothing, and deleting a symlink's target should remove its stale search data.
  6. Confluence enrollment: hiding enrollment when the OAuth client isn't configured, choosing an identity option when one is missing, disabled or ambiguous, and checking that enrolling grants no crawler access.
  7. Org personal tokens: losing org membership should cut off the token, the token should survive deletion of the workspace it came from, and it should be manageable from another workspace. The GitLab token migration script has no tests at all.

Still fully covered on real Postgres: revoked enrollment, stale-access denial, and suspension on the next sync.

@waleedlatif1
waleedlatif1 merged commit 9939762 into staging Oct 13, 2026
36 of 38 checks passed
@waleedlatif1
waleedlatif1 deleted the chore/remove-quarantined-integration branch October 13, 2026 03:00
@greptile-apps

greptile-apps Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Low impact] This PR appears safe to merge; no actionable defects were found.

Summary

Removes seven quarantined integration suites and their exclusion list.

  • Seven quarantined integration suites leave the repository.
  • Integration runs no longer skip suites by name.

No actionable issues found. Tests were not run.

waleedlatif1 acknowledged the remaining coverage gaps and deferred replacement coverage for provider access loss to a follow-up PR.

Reviews (1) · Last reviewed commit: "chore(tests): remove quarantined integra..." · Reviewed by Greptile

This branch was successfully deployed

1 active deployment
Preview — ad947f82 Deployed Oct 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant