Repository navigation
chore(tests): remove the seven quarantined integration suites - #8953
Merged
Merged
Conversation
The seven suites excluded from the integration run since 2026-09-25 failed against a freshly provisioned database (fixtures predate connector and credential changes) and never ran in CI. Delete them, the quarantine list in vitest.config.ts, their explicit-any baseline entries, and getCredentialGroupOAuthContext (plus its @sim/testing mock), whose only caller was the GitHub member suite. The testing rule now says to fix or delete a failing suite rather than exclude it.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
These behaviors were asserted only by the deleted suites. None of them ever ran in CI.
Still fully covered on real Postgres: revoked enrollment, stale-access denial, and suspension on the next sync. |
Contributor
|
This was referenced Oct 13, 2026
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Seven integration suites have been excluded in
apps/sim/vitest.config.tssince 2026-09-25. They fail against a freshly provisioned database because their fixtures predate connector and credential changes, so they never run in CI. They gave no coverage and added maintenance and a false sense of safety.excludeis back to the live-test rule only.getCredentialGroupOAuthContextinenrollments.ts, which only the GitHub suite called, and its@sim/testingmock entries. Also remove 6check-explicit-anybaseline entries for the deleted files.sim-testing.md(and its.mdcmirror): fix or delete a failing suite, never exclude it.Coverage note. These suites never ran, so effective coverage doesn't change, but the behaviors they were written for are still untested. The highest-risk one, withdrawing a member's documents when the provider reports lost access (GitHub 403/404, Jira 400, Calendar 404), is being covered by a new real-Postgres integration test in a follow-up PR. The full list, with what still covers each behavior, is in the PR thread below.
Test plan
check:audits(explicit-any baseline, test-patterns)