Repository navigation
fix(e2e): read the visible workspace shell while a streamed page arrives - #8951
Merged
Merged
Conversation
On the production build, a query made mid-stream can also match the next segment's shell that React parks in a hidden <div id="S:n"> until it swaps it in, so the class-only locator hit a strict-mode violation in WebKit. Scope the shell to the visible element, and restore the tablet workflow-controls check #8950 skipped for the same cause.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
There was a problem hiding this comment.
No issues found across 1 file
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.
Turn on auto-fix | Re-trigger cubic
Contributor
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since #8948 moved mobile e2e to a production build,
e2e (mobile, webkit)has failed on every run: staging and every PR since 23:54 UTC. Different checks fail each time (phone chat/resources, phone and tablet workflow controls) with the same error:The second element sits inside
<div hidden id="S:0">. That's where React's streaming SSR holds a finished Suspense segment until its inline script swaps it in.visit()returns at the navigation commit, so on the production build WebKit can query mid-stream and see both copies of the shell. It's transient by design, not an app bug: the visible shell is correct, and React swaps the segment in moments later.contentShell(page)scopes the locator to the visible shell (filter({ visible: true }), Playwright 1.61) at all four call sites. Two visible shells would still fail strict mode, so nothing is weakened.tablet/workflow controls, which failed from the same cause. The phone chat and phone workflow checks were failing too and weren't covered by that skip.Test plan
e2e (mobile, webkit)ande2e (mobile, chromium)green, including the restored tablet check