Repository navigation
ci(e2e): temporarily skip tablet workflow-controls mobile check - #8950
Merged
Merged
Conversation
Fails on webkit/tablet with a strict-mode violation: '.workspace-content-shell' resolves to two elements (previous Logs page still mounted) after navigating to the workflow. Phone keeps running it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UEUUMctneYa5p25wTg5b57
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No issues found across 1 file
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.
Turn on auto-fix | Re-trigger cubic
Contributor
 |
1 task
waleedlatif1
added a commit
that referenced
this pull request
Oct 13, 2026
…ves (#8951) * Revert "ci(e2e): temporarily skip tablet workflow-controls mobile check (#8950)" This reverts commit 23b0561. * fix(e2e): read the visible workspace shell while a streamed page arrives On the production build, a query made mid-stream can also match the next segment's shell that React parks in a hidden <div id="S:n"> until it swaps it in, so the class-only locator hit a strict-mode violation in WebKit. Scope the shell to the visible element, and restore the tablet workflow-controls check #8950 skipped for the same cause.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporarily skips
tablet/workflow controls open and return to the canvasin the mobile e2e suite. It fails on staging (run) with a strict-mode violation: after navigating to the workflow,.workspace-content-shellresolves to two elements (the previous Logs page's shell is still in the DOM, hidden), sovisit()'stoBeVisible()fails. 94/95 checks pass; the phone variant of this check still runs.Diff is a
viewport.name !== 'tablet'guard plus re-indent. Revert oncevisit()scopes the shell locator (or the stale shell unmount is fixed).🤖 Generated with Claude Code
https://claude.ai/code/session_01UEUUMctneYa5p25wTg5b57