Repository navigation
fix(ci): require native boundary responses after bounded reset retries - #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main’s Windows AMD64 native check failed while reading the HTTP response to a hostile loopback POST (
ConnectionResetError: WinError 10054, run 38034106161). Setup GET had passed; the log does not establish the reset’s cause.The smoke helper now retries only connection-reset exceptions before an HTTP response, at most three attempts. Each Host/Origin case must still independently receive HTTP 403. Persistent resets, accepted requests, wrong HTTP status, and unrelated transport/protocol errors fail; response handles are closed. Production launcher behavior is unchanged.
Validation: all 10 native helper tests passed, including six new regression methods and an actual loopback server that disconnects before returning 403 for both headers; a freshly built macOS ARM64 native-channel executable passed setup, sanitized status, both boundaries, and graceful stop. Independent read-only 6.1 Sol review found no actionable issue. Existing
test_native*.pyCI discovery includes the regression file.Exception handling follows the Python urllib error model:
HTTPErroris handled before itsURLErrorparent; only an actual reset reason is retried. Cloud native installation checks remain required before merge.