Repository navigation
Conversation
corona10
reviewed
Oct 21, 2026
Comment on lines
+2230
to
+2236
| AC_MSG_ERROR([--enable-bolt is incompatible with the Cortex-A53 erratum 843419 workaround. | ||
| BOLT does not preserve protection against this erratum. Its output must not run | ||
| on affected Cortex-A53 processors, including during the build. | ||
| If the generated binaries will never run on affected processors, disable the | ||
| workaround explicitly. With GCC, configure with | ||
| LDFLAGS_NODIST="-mno-fix-cortex-a53-843419". Also remove any explicit | ||
| -Wl,--fix-cortex-a53-843419 linker flags.]) |
There was a problem hiding this comment.
It would be good to explain something like
--enable-bolt is incompatible with the Cortex-A53 erratum 843419 workaround.
With GCC, configure with LDFLAGS_NODIST="-mno-fix-cortex-a53-843419".
Also remove any explicit -Wl,--fix-cortex-a53-843419 linker flags.
See: https://github.com/llvm/llvm-project/pull/187955
corona10
reviewed
Oct 21, 2026
| BOLT versions before LLVM 16 are known to crash BOLT under some scenarios. | ||
| Use of LLVM 16 or newer for BOLT optimization is strongly encouraged. | ||
|
|
||
| BOLT does not preserve protection against Cortex-A53 erratum 843419. Binaries |
corona10
reviewed
Oct 21, 2026
| ], [], [-Werror]) | ||
| # Compiler drivers may enable the workaround without an explicit build flag. | ||
| # Inspect the linker command so that compiler defaults are checked as well. | ||
| AS_CASE([$host_cpu], [aarch64*|arm64], [ |
There was a problem hiding this comment.
[aarch64*] would be enough.
See: https://github.com/python/cpython/blob/c72b435023772118defd96baee5e4cf3a69e4a34/config.sub#L1132
zaniebot
force-pushed
the
bolt-cortex-a53-guard
branch
from
October 22, 2026 19:05
8c78b93 to
dd08538
Compare
zaniebot
changed the title
zanieb
reviewed
Oct 22, 2026
zanieb
force-pushed
the
bolt-cortex-a53-guard
branch
from
October 22, 2026 20:18
9a0411e to
edff69c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent BOLT versions reject AArch64 binaries containing Cortex-A53 erratum 843419 workaround veneers by default. Report an earlier error from
configure --enable-boltwhen build flags explicitly request the workaround. The check only inspects explicit flags because recent BOLT already diagnoses veneers produced by compiler defaults.Document that BOLT output must not run on affected processors and how to override GCC's default workaround with
LDFLAGS_NODIST="-mno-fix-cortex-a53-843419"for builds confined to unaffected hardware. Explicit enabling flags must be removed separately.