Repository navigation
Preserve slug content with custom word delimiters - #94
Open
ShahadatTest wants to merge 1 commit into
Open
ShahadatTest wants to merge 1 commit into
ShahadatTest wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generate_slug('status', 'st') currently returns 'atu': str.strip treats the delimiter as a set of characters and removes actual letters from the word. The same issue affects textual or mixed letter/punctuation separators. Join the recognized word runs with the literal delimiter so only input punctuation/whitespace is removed at the boundaries.
The new content-preservation test fails against original master, while literal punctuation/backslash/empty-delimiter controls pass. The existing slug test and both new tests pass after the fix. Independent Python 3.10 checks cover four custom-delimiter cases and 5,000 comparisons with original behavior for ordinary delimiters; all pass. Flake8 and diff checks pass.
Full Python 3.12 unittest run: 71 tests, with the same 1 failure and 5 errors as pristine master's 69-test run in this Windows environment. These are the existing HOME/path checks, terminal/CLI capture and MockedProgram cases; the affected slug tests pass. No clean full suite or historical Python 2.7-3.9 matrix is claimed.
Found through source inspection and local reproduction for
Aro 2ta koro(make two more contributions). Prepared with OpenAI Codex (GPT-6) assistance, including investigation, implementation, testing and PR preparation. No personal production usage or human code review is claimed.