Skip to content

When creating an internal DTD, external cannot be nil #215

Closed

Description

@slimdave

In f82dfd2 looks like external, system, and name were made non-nullable.

That was reverted for name in 2852b92

But it seems that it's not now possible to produce an internal DTD, because external cannot be nil?

Activity

  1. cfis commented on Sep 29, 2024

    @cfis
    Member

    Sorry, not following. What would you like to change?

  2. slimdave commented on Sep 30, 2024

    @slimdave
    Author

    Can nil be passed for the value of external in the initializer for ext/libxml/ruby_xml_dtd.c?

  3. cfis commented on Oct 1, 2024

    @cfis
    Member

    Ah. Ok looks like no, it has to be set. Want to create a PR?

  4. slimdave commented on Oct 4, 2024

    @slimdave
    Author

    I don't really know any C I'm afraid

  5. added a commit that references this issue on Apr 8, 2026
    ff49ee3
  6. cfis commented on Apr 8, 2026

    @cfis
    Member

    Finally fixed this - will be in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions