Skip to content

_get(Vec) and _get(Mat) should not allocate memory internally #18

Open

Description

@wrtobin

_get(Vec) and _get(Mat) currently allocate the output array, but the user aware of what the array size needs to be, should change the output semantics so the memory allocation happens in user-space. Both for simplicity in terms of memory ownership and so the same array can be used to retrieve values multiple times since that is much more efficient.

Activity

  1. changed the title [-]_get(Vec) and _get(Mat) currently allocate the output array, but the user aware of what the array size needs to be, should change the output semantics so the memory allocation happens in user-space. Both for simplicity in terms of memory ownership and so the same array can be used to retrieve values multiple times since that is much more efficient.[/-] [+]_get(Vec) and _get(Mat) should not allocate memory internally[/+] on May 3, 2018
  2. self-assigned this
    on May 3, 2018
  3. added
    bugSomething isn't working
    enhancementNew feature or request
    invalidThis doesn't seem right
    and removed
    bugSomething isn't working
    on May 3, 2018
  4. wrtobin commented on May 3, 2018

    @wrtobin
    OwnerAuthor

    should the interface change from _get(XXX, ..... , scalar ** vals) to _get(XXX, ....., scalar * vals) since the user in now responsible for allocating the output array?

    this would reduce ambiguity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or requestinvalidThis doesn't seem right

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions