Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a drive (Thinkpad Ultraslim DVD) that can't read the Q subchannel correctly (I think) and gives a lot of CRC errors. cdrdao gives up reading these and ends up writing pregaps equal to the track's start offset, it then subtracts the pregap from previous track's length, which causes whipper to fail with libdiscid rejecting the TOC with
discid.disc.TOCError: Disc too long.Bascially it ends up writing
FILE 0 [track absolute end offset]andSTART track's absolute start offset.Whipper currently doesn't handle this, but the initial fast TOC
cdrdao read-toc --fast-tocactually works. The rip would work with the fix (AccurateRip completely matched), so I think the huge amount of CRC error is just noise.The fix in toc.py
When FILE has start == 0 on trackNumber > 1:
reassigned).