Repository navigation
Hide private filesystem paths in internal rip logs - #718
Open
ajzrva-sys wants to merge 1 commit into
Open
ajzrva-sys wants to merge 1 commit into
ajzrva-sys wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #652.
The internal logger currently copies
TrackResult.filenameinto shared rip logs, which can expose usernames and mount-point names. For example,/home/private-user/Music/Album/Disc 1/01.flacwill now appear asDisc 1/01.flacwhen the log is written in the album directory.Program.writeLog()passes the log directory to the built-in logger. Tracks within that directory retain their relative subdirectories and filenames; tracks outside it use only their basename. Without directory context, safe relative paths retain their existing spelling, while absolute or escaping paths use basenames.This changes log presentation only. Internal track paths remain unchanged for ripping, verification, recovery, cue sheets, and playlists. The existing logger plugin calling convention is preserved.
This PR is based directly on
developand contains only the privacy correction and its regression tests. It does not include or depend on #711, #702, or #706.Validation
writeLog()preserving its partial-log behavior; that resolution is not included here. Additional simulated full/partial-rip checks verify path privacy and digests, including HTOA failures.