Skip to content

Hide private filesystem paths in internal rip logs - #718

Open
ajzrva-sys wants to merge 1 commit into
whipper-team:developfrom
ajzrva-sys:fix/652-log-path-privacy
Open

ajzrva-sys wants to merge 1 commit into
whipper-team:developfrom
ajzrva-sys:fix/652-log-path-privacy

Conversation

@ajzrva-sys

Copy link
Copy Markdown

Fixes #652.

The internal logger currently copies TrackResult.filename into shared rip logs, which can expose usernames and mount-point names. For example, /home/private-user/Music/Album/Disc 1/01.flac will now appear as Disc 1/01.flac when the log is written in the album directory.

Program.writeLog() passes the log directory to the built-in logger. Tracks within that directory retain their relative subdirectories and filenames; tracks outside it use only their basename. Without directory context, safe relative paths retain their existing spelling, while absolute or escaping paths use basenames.

This changes log presentation only. Internal track paths remain unchanged for ripping, verification, recovery, cue sheets, and playlists. The existing logger plugin calling convention is preserved.

This PR is based directly on develop and contains only the privacy correction and its regression tests. It does not include or depend on #711, #702, or #706.

Validation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Track Filename in log file can contain identifiable information - filename should only contain the relative path

1 participant