Repository navigation
Guard CD-R eject and peak/quality crashes (#619, #601, #621) - #705
Open
ajzrva-sys wants to merge 1 commit into
Open
ajzrva-sys wants to merge 1 commit into
ajzrva-sys wants to merge 1 commit into
Conversation
…team#601, whipper-team#621) - CD-R / unknown-metadata refusal paths now honour --eject always/failure (issue whipper-team#619) - Peak level and rip quality prints tolerate None after soxi or rip-task failures (issue whipper-team#601) - ReadTrackTask does not ZeroDivision-crash on zero duration or unreadable frames when computing speed/quality (issue whipper-team#621) - WhipperLogger writes Peak level safely when peak is None (complements open PR whipper-team#694) Signed-off-by: ajzrva-sys <ajzrva-sys@users.noreply.github.com> Addresses whipper-team#619, whipper-team#601, whipper-team#621
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refusing a CD-R or an unknown disc skips the requested eject policy. This applies
--eject alwaysand--eject failureto those exits too.Missing peak or quality values can also crash reporting. They now print as unknown. The log accepts a missing peak, and quality/speed calculations handle unread frames and zero elapsed time.
Addresses #619, #601 and #621. Related to #694.
Checked
6a174b2on macOS arm64 / Python 3.11: 124 unit tests pass. No optical-drive test in this run.