Repository navigation
Allow --help when no CD-DA drive is present - #703
Open
ajzrva-sys wants to merge 1 commit into
Open
ajzrva-sys wants to merge 1 commit into
ajzrva-sys wants to merge 1 commit into
Conversation
BaseCommand no longer requires a drive while building the parser. --help / -h (including subcommand help such as `whipper cd rip --help`) exit successfully without hardware. Actual commands still raise "No CD-DA drives found!" when no device is available. Rip.add_arguments no longer looks up drive info when opts.device is None, and _CD.do() reports a clear error if no device was resolved. Signed-off-by: ajzrva-sys <ajzrva-sys@users.noreply.github.com> Fixes whipper-team#164
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
whipper cd --helpfails without an optical drive because device validation runs before help is shown.Allow
-hand--helpthrough, including subcommand help. Commands that need a drive still fail when none is available.Includes tests for help, default devices and missing devices.
Fixes #164
Checked
eb15b70on macOS arm64 / Python 3.11: 123 unit tests pass. No optical-drive test in this run.