Repository navigation
Conversation
Signed-off-by: Mirko Köster <git@mirkokoester.de> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
mkoester
marked this pull request as ready for review
July 21, 2026 12:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
--no-htoaoption towhipper cd ripthat skips ripping Hidden TrackOne Audio (HTOA) even when it is detected.
Motivation
On some drives, reading the pregap where HTOA lives is extremely slow, so a rip
that detects HTOA stalls on "track 0" and makes little to no progress —
effectively never finishing. This has been reported in #281 (rip stuck at
"track 0 of N", 0%) and is related to the drive-dependent pregap-reading
behaviour in #75. There is currently no way to opt out of HTOA ripping, so the
only workaround is to use a different drive or ripper for those discs.
--no-htoalets users skip HTOA on such drives while still ripping the rest ofthe disc normally. It defaults to off, so existing behaviour is unchanged
unless the flag is passed.
Behaviour
When HTOA is detected and
--no-htoais given, whipper logs that it is skippingit and continues straight to track 1:
Without the flag, behaviour is unchanged (HTOA is ripped as before).
Testing
python3 -m unittest discover→Ran 117 tests ... OK.--no-htoathe rip stallsindefinitely on "track 0"; with the flag it logs the skip, rips all remaining
tracks, and they AccurateRip-verify clean.
I did not add an automated test for the flag itself: the option only gates the
HTOA branch inside
Rip.rip(), which drives the full cdparanoia pipeline andhas no existing unit-test harness (no rip-flow or rip-option is currently
covered). Happy to add coverage if you can point me at the preferred approach.
Docs
man/whipper-cd-rip.rstdocuments the new option.CHANGELOG.mdis leftuntouched as it is generated at release time.
Signed-off-by: Mirko Köster git@mirkokoester.de
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com