You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This has been mentioned in the other PR, and I remember a couple of random build failures in the past. Can someone point me to a failed build or provide intel? Let's try to come up with a fix. ⚡
Pretty sure this is a cascading failure in the adapter specs. Seems the most common culprit is the Reel adapter spec. If it fails, the next adapter test fails too. I struggled with the flakiness of these tests for a long time. They pass consistently on my machine every time, but not so much on Travis.
@lgierth@seancribbs @robgleeson made a new branch to hopefully fix some spec fails, will make a PR when it looks good to you, it also changes how adapters work, so i can implement #153.
Activity
samwgoldman commentedon Oct 22, 2013
Pretty sure this is a cascading failure in the adapter specs. Seems the most common culprit is the Reel adapter spec. If it fails, the next adapter test fails too. I struggled with the flakiness of these tests for a long time. They pass consistently on my machine every time, but not so much on Travis.
tarcieri commentedon Oct 22, 2013
Can you point me at one of the Reel failures?
samwgoldman commentedon Oct 22, 2013
Here's a JRuby test run where the Reel adapter fails. Later, the Rack adapter fails.
https://travis-ci.org/seancribbs/webmachine-ruby/jobs/12748305
samwgoldman commentedon Oct 23, 2013
Yeah, I previously had the adapter tests do just that (89ce86e). I removed that because I thought I had gotten the servers to play nice and shut down.
Seems like web servers generally expect to be at the center of the universe. Maybe the Adapter#shutdown API is just a pipe dream.
nyarly commentedon Oct 24, 2013
(PR reference was a typo)
tarcieri commentedon Nov 20, 2013
@lgierth hmmm...
This could either be an http_parser.rb bug on a Reel bug. Not sure? /cc @tmm1
tarcieri commentedon Nov 20, 2013
This is possibly inside of Celluloid's
at_exithandler /cc @halorgium36 remaining items
Asmod4n commentedon Feb 23, 2014
nearly all failures i am getting today is because of the default port set in the spec.
Asmod4n commentedon Feb 23, 2014
maybe create a array with a random port for each adapter and have a counter which one to use for the current run.
Asmod4n commentedon Feb 24, 2014
@lgierth @seancribbs @robgleeson made a new branch to hopefully fix some spec fails, will make a PR when it looks good to you, it also changes how adapters work, so i can implement #153.
https://github.com/seancribbs/webmachine-ruby/compare/expose_application
tarcieri commentedon Jun 19, 2014
@headius any ideas?
[-]The randomly failing spec[/-][+]The consistently failing spec[/+]Asmod4n commentedon Apr 24, 2016
@lgierth fixed it by currently ignoring jruby and rbx