Skip to content

truncate: stop comparing a correct size with an overflowed one #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
metif12 wants to merge 1 commit into from
+10 −3
Closed

truncate: stop comparing a correct size with an overflowed one #213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/truncate/truncate_test.v
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,13 @@ fn test_help_and_version() {
rig.assert_help_and_version_options_work()
}

// The three sizes below are written out rather than multiplied out. `size` is a
// u64 and V's int is 32 bits, so `24 * 1000 * 1000 * 1000` overflowed to
// -1769803776 and the assertion was comparing a correct value with a wrapped one:
//
// -24GB 24_000_000_000
// /14PB 14_000_000_000_000_000
// %1E 1_152_921_504_606_846_976
fn test_size_parser() {
mut s := parse_size_opt('0')
assert s.mode == .absolute
Expand All @@ -28,7 +35,7 @@ fn test_size_parser() {

s = parse_size_opt('-24GB')
assert s.mode == .subtract
assert s.size == 24 * 1000 * 1000 * 1000
assert s.size == 24_000_000_000

s = parse_size_opt('<13kB')
assert s.mode == .at_most
Expand All @@ -46,12 +53,12 @@ fn test_size_parser() {

s = parse_size_opt('/14PB')
assert s.mode == .round_down
assert s.size == 14 * 1000 * 1000 * 1000 * 1000 * 1000
assert s.size == 14_000_000_000_000_000
assert s != t

s = parse_size_opt('%1E')
assert s.mode == .round_up
assert s.size == 1 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024
assert s.size == 1_152_921_504_606_846_976

// TODO: Test u64 overflows
}
Expand Down