You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
the values.size is updated but it doesn't really reflect on the network itself.
I wonder if there is any other way to be able to update a node.
I tried nodes.updateOnly(id, props)
it works well, but this cause the network to be updated whenever i select a node.
and this makes my network to be destroyed and recreated and i don't expect this behaviour
looking through the code the icon shape ignores the size and uses it's own icon.size. I don't know why this is and it indeed seems really weird. According to blame it has been this way for the past five years so changing this would likely break a lot of projects.
What if size was used unless icon.size is set and if icon.size is set it would override size. Would it be an acceptable solution?
yes, that would work fine, i think for my understanding, the node size should always have the priority here.
but the solution you proposed looks very acceptable as well.
in this case i would remove the icon.size and use the size property.
that would work perfectly for me
Activity
Thomaash commentedon Jan 27, 2020
Hi @nassif7,
looking through the code the icon shape ignores the size and uses it's own
icon.size. I don't know why this is and it indeed seems really weird. According to blame it has been this way for the past five years so changing this would likely break a lot of projects.What if
sizewas used unlessicon.sizeis set and ificon.sizeis set it would overridesize. Would it be an acceptable solution?nassif7 commentedon Feb 3, 2020
Hi @Thomaash
yes, that would work fine, i think for my understanding, the node
sizeshould always have the priority here.but the solution you proposed looks very acceptable as well.
in this case i would remove the
icon.sizeand use thesizeproperty.that would work perfectly for me
thanks