Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 0.20.2. Merging this to
maintagsv0.20.2and dispatchesspec-releasedto the SDK repos.Merge with a merge commit, not a squash.
What it fixes
One conformance fixture.
expression-retired-member-patterndestructured a retired member through an arrow parameter —(({ bodyText }) => …)(response)— which is dataflow: knowing thatbodyTextcame fromresponsemeans following an argument into a function.UTOS-E070deliberately stops at what a parser sees directly, whichtemplate-expressions.md§ Retired members states as a member expression on the scope name, orconst { bodyText } = response. The fixture now uses that spelling; the arrow form is still refused at evaluation by the throwing member (UTOS-E120).Passing the old fixture would have meant implementing a static analysis the spec does not ask for, in every implementation.
Why it is a release of its own
v0.20.1was tagged before #68 merged, so the fix missed it. The changelog had it listed under 0.20.1 regardless, which #69 corrected — each entry now describes what its tag actually holds.No rules change meaning and no protos change. With this corpus,
utos/sdk-dotnetpasses all 190 of its tests (#54).