Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 0.20.1, a correction that changes no behaviour. Merging this to
maintagsv0.20.1and dispatchesspec-releasedto the SDK repos.Merge with a merge commit, not a squash, as
dev->mainalways is.What it fixes
Two conformance fixtures asserted what 0.20.0 had just retired or renamed, so every conforming implementation would have failed them.
sdk-dotnetfound them within minutes of running the corpus:emission-rule-without-actionexpectedUTOS-C504, retired in 0.20.0. It is renamedonemitted-rule-without-effect-or-exitand expects the rewordedUTOS-T001— which is what anonEmittedrule carrying neither an effect nor an exit now breaks, so the case keeps its point.dispatch-bad-start-activityexpected a path throughhandle. Its bundle was migrated to theworkflow.calleffect; its expected path was not.No rule changes meaning and no proto changes, which is what makes this a patch rather than a minor. An implementation need not follow a patch — but one running the corpus will want this one.
Note for the SDK sync
sdk-dotnetis mid-implementation of 0.20.0 and will pick these up in its own branch rather than through a second vendor PR.