This repository was archived by the owner on Jul 16, 2022. It is now read-only.
Repository navigation
This repository was archived by the owner on Jul 16, 2022. It is now read-only.
Proper fsync on Windows #18
Description
See #6. This blogpost covers this issue in great detail. For Windows, this is mentioned:
On Windows, using FlushFileBuffers() is probably the way to go.
Not really a confident statement, more research needed.
Activity
untitaker commentedon Jul 26, 2016
We currently use _commit, which doesn't try to flush disk buffers. However, there is no indication that FlushFileBuffers is different in that regard.
Dobatymo commentedon Sep 15, 2020
First:
_commitcallsFlushFileBuffersinternally (according to https://stackoverflow.com/a/1947818). Second: Where do you actually call_commit?untitaker commentedon Sep 15, 2020
os.fsyncis documented as calling_commit. I guess then this issue is not actionable