Skip to content

Allow custom axis scales through common component - #7

Merged
huntc merged 4 commits into
titanclass:masterfrom
RoryStokes:configurable-axis-scales
Jan 18, 2022
Merged

huntc merged 4 commits into
titanclass:masterfrom
RoryStokes:configurable-axis-scales

Conversation

@RoryStokes

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread src/axis.rs Resolved
Comment thread src/axis.rs Resolved
Comment thread src/horizontal_axis.rs Resolved
Comment thread src/time_axis_scale.rs Resolved
@huntc

huntc commented Jan 16, 2022 •

Copy link
Copy Markdown
Contributor

Many clippy errors which are failing CI also. Don't forget cargo clippy is your friend. :-)

@huntc huntc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly there!

Comment thread src/axis.rs Resolved
Comment thread src/horizontal_axis.rs Resolved
Comment thread src/horizontal_series.rs Resolved

@huntc huntc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@RoryStokes
RoryStokes force-pushed the configurable-axis-scales branch from 937debd to 1b59bf9 Compare January 18, 2022 06:36
@huntc
huntc merged commit 0719863 into titanclass:master Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants