Repository navigation
bazel coverage failure 0.9.0 -> 0.10.0 #74
Description
Hi I'm attempting to upgrade rules_opa from 0.9.0 to 0.10.0. It looks like coverage support was added in 0.10.0, however, I can't seem to make it work. The tests without coverage are passing, but with coverage, I'm getting:
% bazel coverage --combined_report=lcov //my_project:opa_lib_test
INFO: Build option --instrumentation_filter has changed, discarding analysis cache.
INFO: Analyzed target //my_project:opa_lib_test (0 packages loaded, 3783 targets configured).
INFO: Found 1 test target...
FAIL: //my_project:opa_lib_test (see /tmp/bazel_cache/execroot/videoamp/bazel-out/darwin_arm64-fastbuild/testlogs/my_project/opa_lib_test/test.log)
INFO: From Testing //my_project:opa_lib_test:
==================== Test output for //my_project:opa_lib_test:
Traceback (most recent call last):
File "/tmp/bazel_cache/sandbox/darwin-sandbox/11969/execroot/videoamp/bazel-out/darwin_arm64-fastbuild/bin/my_project/opa_lib_test_test.sh.runfiles/rules_opa/tools/opa_coverage.py", line 109, in <module>
main(sys.argv)
File "/tmp/bazel_cache/sandbox/darwin-sandbox/11969/execroot/videoamp/bazel-out/darwin_arm64-fastbuild/bin/my_project/opa_lib_test_test.sh.runfiles/rules_opa/tools/opa_coverage.py", line 87, in main
result = CoverageReport.from_dict(json.loads(proc.stdout))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/tmp/bazel_cache/sandbox/darwin-sandbox/11969/execroot/videoamp/bazel-out/darwin_arm64-fastbuild/bin/my_project/opa_lib_test_test.sh.runfiles/rules_opa/tools/opa_coverage.py", line 63, in from_dict
files={
^
File "/tmp/bazel_cache/sandbox/darwin-sandbox/11969/execroot/videoamp/bazel-out/darwin_arm64-fastbuild/bin/my_project/opa_lib_test_test.sh.runfiles/rules_opa/tools/opa_coverage.py", line 64, in <dictcomp>
file: CoverageFile.from_dict(report)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/tmp/bazel_cache/sandbox/darwin-sandbox/11969/execroot/videoamp/bazel-out/darwin_arm64-fastbuild/bin/my_project/opa_lib_test_test.sh.runfiles/rules_opa/tools/opa_coverage.py", line 49, in from_dict
coverage=float(data.get("coverage")),
^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: float() argument must be a string or a real number, not 'NoneType'
I've tried this on several architectures, and we're still on bazel 6.2.1 which might be the problem.
Activity
ffortier commentedon Feb 2, 2025
Hello, which version of opa do you use?
I'm managed to get a working setup with bazel 6.2.1 in this repo using the legacy
WORKSPACEsetup and the current default 0.65.0. You can check the branch bazel-6.2.1-coverage and runbazel coverage //examples/... --combined_report=lcov. It works.Can you reproduce your issue in github with a minimal setup that I can look at?
rajukrishnamurthy commentedon Feb 3, 2025
Hi, we're just using the default, so 0.65.0.
Our setup is pretty involved, but I will give it a stab later this week.
Just taking a quick look at your WORKSPACE file was curious if you think the versions of rules_python or protobuf would matter? For rules_python, we're on 0.39 with python 3.11 as the default. protobuf is pretty old 27.x. I'm the process of upgrading those, so perhaps this is something that is self correcting. Also, we don't pull in rules_cc or llvm, but I doubt that would make any difference.