Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
<PackageVersion Include="OneOf" Version="3.0.271" />
<PackageVersion Include="OneOf.SourceGenerator" Version="3.0.271" />
<PackageVersion Include="Polly" Version="8.8.0" />
<PackageVersion Include="Polyfill" Version="11.4.2" />
<PackageVersion Include="Polyfill" Version="11.4.3" />
<PackageVersion Include="PublicApiGenerator" Version="11.5.4" />
<PackageVersion Include="RandomDataGenerator.Net" Version="1.0.19.1" />
<PackageVersion Include="Shouldly" Version="4.3.0" />
Expand Down
2 changes: 1 addition & 1 deletion src/TUnit.Templates/content/TUnit/TestProject.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<ItemGroup>
<PackageReference Include="TUnit" Version="1.7*" />
<!--#if (IsNetFramework) -->
<PackageReference Include="Polyfill" Version="11.4.2" PrivateAssets="all" />
<PackageReference Include="Polyfill" Version="11.4.3" PrivateAssets="all" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Template dependency lacks build coverage
The updated Polyfill version is used when the template generates a .NET Framework project, but the net48 template test removes package versions from its snapshot and the template pipeline only creates projects without building them. A restore or build problem with this version could therefore go undetected until someone uses the generated project. Consider adding a restore/build check for a generated .NET Framework project.

Knowledge Base Used: Observability, ecosystem extensions, and delivery

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

<!--#endif -->
<!--#if (enableDotCover) -->
<PackageReference Include="JetBrains.dotCover.Framework" Version="1.0.2" />
Expand Down
Loading