Repository navigation
Conversation
Calculate actual size of copier module gateway config. Copy and store it in copier_data. It needs to be available even after copier is created e.g. during SET_PIPELINE_STATE IPC when dai_config_dma_channel() is called second time and DMA config is used to assign dma_channel_id value. Signed-off-by: Ievgen Ganakov <ievgen.ganakov@intel.com>
|
cherry pick of commit 415aab5 in PR #8361 |
|
I tested multiple times in LNLM_SDW_AIOC but still seeing |
|
@plbossart please check 4cc9d54. At first we save the gateway config, but it was deleted |
| if (copier->gtw_cfg.config_length) { | ||
| gtw_cfg_size = copier->gtw_cfg.config_length << 2; | ||
| gtw_cfg = rzalloc(SOF_MEM_ZONE_RUNTIME, 0, SOF_MEM_CAPS_RAM, | ||
| gtw_cfg_size); |
There was a problem hiding this comment.
please use rmalloc() - you overwrite it completely 5 lines later
| } | ||
|
|
||
| ret = memcpy_s(gtw_cfg, gtw_cfg_size, &copier->gtw_cfg.config_data, | ||
| gtw_cfg_size); |
There was a problem hiding this comment.
why we can't directly copy data into cd->gtw_cfg with:
ret = memcpy_s(&cd->gtw_cfg, gtw_cfg_size, &copier->gtw_cfg.config_data,
gtw_cfg_size);
|
@plbossart @fredoh9 Let me submit a proper fix for DMIC and SSP, we've already tested it internally. SNDW needs additional changes related to blob format which is now different for Linux and Windows |
Calculate actual size of copier module gateway config. Copy and store it in copier_data. It needs to be available even after copier is created e.g. during SET_PIPELINE_STATE IPC when dai_config_dma_channel() is called second time and DMA config is used to assign dma_channel_id value.