Repository navigation
pipeline: add a flag for FW xrun recovery disabling - #833
Conversation
|
@lgirdwood could you please review this firstly, once it is merged, I will submit my next series which verified that to make both with and without NO_XRUN_RECOVERY, we can handle FW initiated Xrun nicely. I think that will fix our FW Xrun recovery thoroughly and all related issues will be benefited. |
f32368a to
4590fef
Compare
|
@lgirdwood updated. |
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
Looks like there is a CI issue too.
There was a problem hiding this comment.
This should return 0 so it always succeeds (except where it may fail on system that have XRUN recovery in FW enabled).
There was a problem hiding this comment.
This should return 0 so it always succeeds (except where it may fail on system that have XRUN recovery in FW enabled).
with the logic inside pipeline_task(), if we return 0 here, it means xrun recover success, it will continue copy or next schedule(those will fail again), that's not what we want?
I can't access quickbuild.igk.intel.com, can you share me the error detail? |
|
@keyonjie pls apply for access. |
thanks, got it now. @lgirdwood looks the QB error is because of network issue, not of the PR code itself. |
|
@zrombel fyi, looks like a CI server may need kicked by you ;) |
|
@keyonjie can you rebase. CI is back now working. |
|
@keyonjie looks like you need to rebase. |
@lgirdwood done. |
Add a flag NO_XRUN_RECOVERY to disable the FW internal xrun recovery, make it to false by default. Signed-off-by: Slawomir Blauciak <slawomir.blauciak@linux.intel.com> Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
This is PR [1/2] of Xrun recovery fixes and [1/5] of fixes of #800.
Add a flag NO_XRUN_RECOVERY to disable the FW internal xrun recovery,
make it to false by default.
Signed-off-by: Slawomir Blauciak slawomir.blauciak@linux.intel.com
Signed-off-by: Keyon Jie yang.jie@linux.intel.com