Skip to content

tools: moving rimage and logger to tools directory - #618

Closed
bkokoszx wants to merge 1 commit into
thesofproject:masterfrom
bkokoszx:tools-relocation
Closed

tools: moving rimage and logger to tools directory#618
bkokoszx wants to merge 1 commit into
thesofproject:masterfrom
bkokoszx:tools-relocation

Conversation

@bkokoszx

@bkokoszx bkokoszx commented Nov 22, 2018

Copy link
Copy Markdown
Collaborator

I've moved rimage and logger (from soft repo) to tools
directory. Cmds for building tools:
./autogen.sh
./configure --enable-tools
make
sudo make install

Signed-off-by: Bartosz Kokoszko bartoszx.kokoszko@linux.intel.com

@bkokoszx bkokoszx mentioned this pull request Nov 22, 2018
Closed
@bkokoszx

bkokoszx commented Nov 22, 2018

Copy link
Copy Markdown
Collaborator Author

CI fails because of changing ./configure --enable-rimage to ./configure --enable-tools.

@lgirdwood

lgirdwood commented Nov 22, 2018

Copy link
Copy Markdown
Member

@bkokoszx, Ok, will merge it tonight so that @xiulipan can update CI.

@cujomalainey

cujomalainey commented Nov 22, 2018

Copy link
Copy Markdown
Contributor

I was going to do the merge this weekend, this will preserve this history of the files if that is of importance

@lgirdwood

lgirdwood commented Nov 22, 2018

Copy link
Copy Markdown
Member

@cujomalainey ok, if you are good to go we can take your PR over the weekend otherwise we can merge this one on Monday and forget the history. @bkokoszx this OK with you ?

@cujomalainey

cujomalainey commented Nov 22, 2018

Copy link
Copy Markdown
Contributor

Sorry for the delay on this, the merge was more complex than expected

@xiulipan

xiulipan commented Nov 23, 2018

Copy link
Copy Markdown
Contributor

@bkokoszx
Please update the scripts/xtensa-build-all.sh and scripts/rimage-build.sh
@lgirdwood
The CI did not call the configure directly, update the scripts will automatic fix the issues.

@bkokoszx

bkokoszx commented Nov 23, 2018

Copy link
Copy Markdown
Collaborator Author

@lgirdwood @cujomalainey
Ok, no problem. We can wait until Monday

@bkokoszx
bkokoszx requested a review from jajanusz as a code owner November 23, 2018 06:31
@bkokoszx

bkokoszx commented Nov 23, 2018

Copy link
Copy Markdown
Collaborator Author

@lgirdwood @xiulipan
I've updated CI scripts.

jajanusz
jajanusz reviewed Nov 23, 2018
View reviewed changes

@jajanusz jajanusz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should rename rimage-build.sh to tools-build.sh because it builds tools now, not only rimage. Everything else looks good

@xiulipan

xiulipan commented Nov 23, 2018

Copy link
Copy Markdown
Contributor

@jajanusz
good idea, can we duplicate one tools-build.sh at first. And after we solve the CI dependency issue, I will remove the old one in the CI update PR.

@jajanusz

jajanusz commented Nov 23, 2018

Copy link
Copy Markdown
Contributor

@xiulipan
Sounds like a good solution for now

@bkokoszx
tools: moving rimage and logger to tools directory
5aaf959 
I've moved rimage and logger (from soft repo) to tools
directory. Cmds for building tools:
./autogen.sh
./configure --enable-tools
make
sudo make install

Signed-off-by: Bartosz Kokoszko <bartoszx.kokoszko@linux.intel.com>
@bkokoszx

bkokoszx commented Nov 23, 2018

Copy link
Copy Markdown
Collaborator Author

@jajanusz @xiulipan
I've added tools-build.sh

@lgirdwood

lgirdwood commented Nov 23, 2018

Copy link
Copy Markdown
Member

@bkokoszx since we will merge the PR with history from @cujomalainey (if his time permits), can you redo this PR to only contain the new build script which I will merge today.

@bkokoszx

bkokoszx commented Nov 23, 2018 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

@lgirdwood
Do you mean only makefile changes and build script without logger in tools directory?

@bkokoszx

bkokoszx commented Nov 27, 2018

Copy link
Copy Markdown
Collaborator Author

#624 was merged.

I close this PR.

@bkokoszx bkokoszx closed this Nov 27, 2018
@xiulipan

xiulipan commented Nov 28, 2018

Copy link
Copy Markdown
Contributor

@bkokoszx
will we later move rimage into tools?

@bkokoszx
bkokoszx deleted the tools-relocation branch February 4, 2019 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lbetlej lbetlej Awaiting requested review from lbetlej
@lgirdwood lgirdwood Awaiting requested review from lgirdwood
@mmaka1 mmaka1 Awaiting requested review from mmaka1
@plbossart plbossart Awaiting requested review from plbossart
1 more reviewer
@jajanusz jajanusz jajanusz left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@xiulipan xiulipan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bkokoszx @lgirdwood @cujomalainey @xiulipan @jajanusz