Repository navigation
topology2: build only when alsatplg is v1.2.7 or greater - #6153
Merged
Merged
Conversation
Fixes: thesofproject#5323 The v1.2.6 requirement was a lie the whole time because alsatplg v1.2.6 does not have any `-I` option. The truth was: un-released alsa-utils from git was required. The check for v1.2.6 was an approximation good enough for many users but not for everyone, see for instance thesofproject#5323. Now that alsa-utils v1.2.7 has been released we can stop lying: alsa-project/alsa-utils@7d934f3142549 Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Collaborator
Author
|
This may require a Docker image update, @fredoh9 ? EDIT: maybe not, topology2 is getting built in https://sof-ci.01.org/sofpr/PR6153/build1230/build/tools.txt and also in https://github.com/thesofproject/sof/runs/7886803171 |
marc-hb
marked this pull request as ready for review
August 17, 2022 20:39
marc-hb
requested review from
cujomalainey,
dbaluta,
keqiaozhang,
kv2019i,
libinyang and
plbossart
August 17, 2022 20:41
Collaborator
Author
|
@plbossart is any topology v2 used in validation yet? (I would ask Ranjani but she's on sabbatical) |
Member
only in Intel daily IPC4 tests. topology2 == IPC4 in practice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #5323
The v1.2.6 requirement was a lie the whole time because alsatplg v1.2.6
does not have any
-Ioption. The truth was: un-released alsa-utilsfrom git was required. The check for v1.2.6 was an approximation good
enough for many users but not for everyone, see for instance #5323.
Now that alsa-utils v1.2.7 has been released we can stop lying:
alsa-project/alsa-utils@7d934f3142549
Signed-off-by: Marc Herbert marc.herbert@intel.com