Repository navigation
Drivers: Intel: DMIC: Re-arrange DMIC DAI component data - #4299
Merged
lgirdwood merged 3 commits intoJun 16, 2021
Merged
Conversation
singalsu
force-pushed
the
dmic_cleanup_component_data
branch
3 times, most recently
from
June 4, 2021 17:36
89c58bc to
b5d0394
Compare
singalsu
changed the title
lyakh
requested changes
Jun 7, 2021
singalsu
force-pushed
the
dmic_cleanup_component_data
branch
from
June 7, 2021 11:28
b5d0394 to
a90f747
Compare
lyakh
reviewed
Jun 8, 2021
kv2019i
reviewed
Jun 8, 2021
Collaborator
There was a problem hiding this comment.
@singalsu One downside is that this memory cannot be freed even if all dmic pipelines are stopped (unless we get dynamic module loading in the future). But this is ~100 bytes, so maybe something that can be optimized later.
Collaborator
Author
lgirdwood
reviewed
Jun 8, 2021
lgirdwood
left a comment
lgirdwood
left a comment
Member
There was a problem hiding this comment.
I also assume here there is no regression in stability ?
singalsu
force-pushed
the
dmic_cleanup_component_data
branch
from
June 9, 2021 08:38
a90f747 to
657a453
Compare
lgirdwood
reviewed
Jun 9, 2021
singalsu
force-pushed
the
dmic_cleanup_component_data
branch
from
June 9, 2021 13:27
657a453 to
c8d9fa1
Compare
singalsu
changed the title
singalsu
marked this pull request as ready for review
June 9, 2021 14:32
Collaborator
Author
@lgirdwood The two alloc() done in dmic_probe() are to SOF_MEM_ZONE_RUNTIME_SHARED. Is that sufficient? |
lyakh
reviewed
Jun 10, 2021
This patch collects the global DMIC driver parameters into single struct. The pointer global in every DMIC DAI instance points into the same data. All access from functions happens via the pointer that simplifies the next step to add NHLT binary data configuration for the driver. The previous dmic_prm[] is no more allocated dynamically since the single data structure is fixed size and not large. It simplifies the driver code that handles the multiple ownership. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Previously the gain ramp updates were executed in core 0 only even if rest of driver was executed in other core. It caused issues with driver state variables in cached memory. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This patch only removes some unnecessary line feeds for better readability. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
force-pushed
the
dmic_cleanup_component_data
branch
from
June 16, 2021 12:05
c8d9fa1 to
c72d2c7
Compare
Collaborator
Author
|
I've split the PR to 3 commits. The fist contains most of the changes. Previously I forgot to mention in commit text that dmic_work() runs on the same core as driver as result of 2nd commit (it was needed to make it work for cached data, now I think it could run on core 0 always but I think this makes more sense). 3rd commit is just cosmetic. |
lgirdwood
approved these changes
Jun 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch separates the component data to private and global
parts and cleans up the explicit un-cache code from previous
version.
Since the dmic_prm[] struct is fixed length it does not need to
be allocated dynamically. It simplifies a lot the parameters
handling and sharing.
Signed-off-by: Seppo Ingalsuo seppo.ingalsuo@linux.intel.com