Skip to content

cmake: add *_overridedefconfig targets - #2704

Merged
lgirdwood merged 2 commits into
thesofproject:masterfrom
jajanusz:overridedefconfigs
Apr 3, 2020
Merged

lgirdwood merged 2 commits into
thesofproject:masterfrom
jajanusz:overridedefconfigs

Conversation

@jajanusz

@jajanusz jajanusz commented Apr 3, 2020 •

Copy link
Copy Markdown
Contributor

Add targets that are meant to be used after defconfig,
to apply configs from /configs/override on top of defconfigs.

Follow up to #2641

jajanusz added 2 commits April 3, 2020 12:51
CMake regeneration condition should depend on directory to automatically
update when new defconfigs are added.

Signed-off-by: Janusz Jankowski <janusz.jankowski@linux.intel.com>
Add targets that are meant to be used after defconfig,
to apply configs from <arch>/configs/override on top of defconfigs.

Signed-off-by: Janusz Jankowski <janusz.jankowski@linux.intel.com>
@jajanusz

jajanusz commented Apr 3, 2020

Copy link
Copy Markdown
Contributor Author

Sample usage:

cmake [CMAKE ARGS] ..
make cannonlake_defconfig
make cannonlake_chrome_overridedefconfig
make bin -j6

@jajanusz jajanusz changed the title Overridedefconfigs cmake: add *_overridedefconfig targets Apr 3, 2020
@paulstelian97

Copy link
Copy Markdown
Collaborator

Sample usage:

cmake [CMAKE ARGS] ..
make cannonlake_defconfig
make cannonlake_chrome_overridedefconfig
make bin -j6

Would any such override be applicable on top of more than one base config? If not, I suggest you make the overrideconfig actually do the base automatically on its own.

@jajanusz

jajanusz commented Apr 3, 2020

Copy link
Copy Markdown
Contributor Author

Sample usage:

cmake [CMAKE ARGS] ..
make cannonlake_defconfig
make cannonlake_chrome_overridedefconfig
make bin -j6

Would any such override be applicable on top of more than one base config? If not, I suggest you make the overrideconfig actually do the base automatically on its own.

They can be stacked and you wouldn't know at 2nd call to override if there was defconfig already, so they have to be sparate make calls.

@lgirdwood
lgirdwood merged commit 99d03de into thesofproject:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants