Repository navigation
ipc: Break ipc_comp_dai_config after first error - #2003
Merged
Merged
Conversation
ktrzcinx
force-pushed
the
ipc_refactor_dai
branch
2 times, most recently
from
October 25, 2019 07:26
d8e70e1 to
32999c7
Compare
tlauda
suggested changes
Oct 25, 2019
tlauda
left a comment
tlauda
left a comment
Contributor
There was a problem hiding this comment.
Multiple typos in commit title and description.
ktrzcinx
changed the title
Added break statement after error, as it was before refactoring
this part of code in commit <89ef0af07612c0bcf1a85fec3871d0c31e60087b>
("ipc: Refactor ipc_comp_dai_config function").
While at it, also removed additional parenthesis around trace_ipc_error.
Signed-off-by: Karol Trzcinski <karolx.trzcinski@linux.intel.com>
ktrzcinx
force-pushed
the
ipc_refactor_dai
branch
from
October 25, 2019 08:26
32999c7 to
7038748
Compare
tlauda
approved these changes
Oct 25, 2019
Contributor
|
SOFCI TEST |
2 similar comments
Contributor
|
SOFCI TEST |
Member
Author
|
SOFCI TEST |
jajanusz
approved these changes
Oct 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1954
#1997
I found some functionality change after refactor, so in this PR it should be repaired.
While at it, also removed additional parenthesis in reference to
#1999