Skip to content

ipc: return an error on dai not found - #1951

Merged
tlauda merged 1 commit into
thesofproject:masterfrom
tlauda:topic/dai-not-found-error
Oct 17, 2019
Merged

ipc: return an error on dai not found#1951
tlauda merged 1 commit into
thesofproject:masterfrom
tlauda:topic/dai-not-found-error

Conversation

@tlauda

@tlauda tlauda commented Oct 16, 2019

Copy link
Copy Markdown
Contributor

Returns an error, when there is no DAI component
connected to the DAI index specified by DAI config
IPC.

Signed-off-by: Tomasz Lauda tomasz.lauda@linux.intel.com

@tlauda
ipc: return an error on dai not found
248eb98 
Returns an error, when there is no DAI component
connected to the DAI index specified by DAI config
IPC.

Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
@tlauda tlauda mentioned this pull request Oct 16, 2019
Closed
@tlauda

tlauda commented Oct 16, 2019

Copy link
Copy Markdown
Contributor Author

SOFCI TEST

@dbaluta

dbaluta commented Oct 16, 2019

Copy link
Copy Markdown
Collaborator

ipc_comp_dai_config really needs some refactoring. Outer switch can be replaced with an if.

@dbaluta dbaluta mentioned this pull request Oct 16, 2019
Closed
@plbossart

plbossart commented Oct 16, 2019

Copy link
Copy Markdown
Member

ACK, this PR helps detect errors right at the config level

kernel dmesg snippet 
[  277.518571] sof-audio-acpi 80860F28:00: ipc tx: 0x30030000: GLB_TPLG_MSG: COMP_CONNECT
[  277.518624] sof-audio-acpi 80860F28:00: ipc tx succeeded: 0x30030000: GLB_TPLG_MSG: COMP_CONNECT
[  277.518635] sof-audio-acpi 80860F28:00: tplg: 1 hw_configs found, default id: 2!
[  277.518642] sof-audio-acpi 80860F28:00: tplg: config SSP0 fmt 0x4001 mclk 19200000 bclk 2400000 fclk 48000 width (24)25 slots 2 mclk id 0 quirks 64
[  277.518651] sof-audio-acpi 80860F28:00: ipc tx: 0x80010000: GLB_DAI_MSG: CONFIG
[  277.518723] sof-audio-acpi 80860F28:00: error: ipc error for 0x80010000 size 12
[  277.518730] sof-audio-acpi 80860F28:00: error: failed to set DAI config for SSP0
[  277.518735] sof-audio-acpi 80860F28:00: ASoC: physical link loading failed
[  277.518765] sof-audio-acpi 80860F28:00: error: tplg component load failed -19
[  277.518778] sof-audio-acpi 80860F28:00: error: failed to load DSP topology -22
[  277.518783] sof-audio-acpi 80860F28:00: ASoC: failed to probe component -22
[  277.518820] sof-nocodec sof-nocodec: ASoC: failed to instantiate card -22
[  277.518930] sof-nocodec: probe of sof-nocodec failed with error -22

plbossart
plbossart approved these changes Oct 16, 2019
View reviewed changes

@plbossart plbossart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR works for me.

Agree with @dbaluta, the switch case should be removed in follow-up patches, it's an eyesore.

@tlauda
tlauda merged commit 844526a into thesofproject:master Oct 17, 2019
@tlauda
tlauda deleted the topic/dai-not-found-error branch November 22, 2019 11:22
@brentlu brentlu mentioned this pull request Jan 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbaluta dbaluta dbaluta approved these changes
@plbossart plbossart plbossart approved these changes
@bardliao bardliao Awaiting requested review from bardliao
@xiulipan xiulipan Awaiting requested review from xiulipan
+1 more reviewer
@jajanusz jajanusz jajanusz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tlauda @dbaluta @plbossart @jajanusz