Repository navigation
ipc: replace fw ready bitfield with explicit bit ordering - #1418
Merged
Merged
Conversation
slawblauciak
force-pushed
the
fw_ready_flags
branch
from
May 13, 2019 12:13
cc9ef73 to
c008957
Compare
slawblauciak
requested review from
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
May 13, 2019 12:13
slawblauciak
force-pushed
the
fw_ready_flags
branch
3 times, most recently
from
May 13, 2019 12:34
6b86557 to
fd630c4
Compare
plbossart
requested changes
May 13, 2019
plbossart
left a comment
plbossart
left a comment
Member
There was a problem hiding this comment.
same as for kernel, ABI MAJOR 4 doesn't seem quite right
Previously the structure used bitfields, which do not guarantee bit ordering. This change makes sure the order is clearly defined. It also renames and repurposes the field for general use, which helps avoid the need to introduce new flag fields. Signed-off-by: Slawomir Blauciak <slawomir.blauciak@linux.intel.com>
slawblauciak
force-pushed
the
fw_ready_flags
branch
from
May 14, 2019 06:42
fd630c4 to
28a69ed
Compare
Collaborator
Author
|
I've removed the ABI version increment. |
jajanusz
approved these changes
May 14, 2019
tlauda
approved these changes
May 14, 2019
Member
|
I'll go ahead and merge the kernel part since there is no objection on the firmware side either. |
Contributor
|
@plbossart please approve this PR after merging SW PR |
plbossart
approved these changes
May 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the structure used bitfields,
which do not guarantee bit ordering.
This change makes sure the order is clearly defined.
It also renames and repurposes the field for general use,
which helps avoid the need to introduce new flag fields.
Signed-off-by: Slawomir Blauciak slawomir.blauciak@linux.intel.com
SW side: thesofproject/linux#937