Skip to content

edf: using specific schedule_edf() instead of schedule() #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmaka1 merged 1 commit into from
Mar 25, 2019
Merged

edf: using specific schedule_edf() instead of schedule() #1164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/edf_schedule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ static void schedule_edf_task_normal(struct task *task, uint64_t start,
/* need to run scheduler if task not already running */
if (need_sched) {
/* rerun scheduler */
schedule();
schedule_edf();

@lgirdwood lgirdwood Mar 21, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you state why in commit message, looks like an optimization or bug fix ?

@bkokoszx bkokoszx Mar 22, 2019

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've add information that is for optimization. In fact, it was my inattention during #1089 PR. We should not use generic functions in specific scheduler implementation.
Effect is the same, because schedule() will also invoke schedule_edf() function.

}
}

Expand Down