Skip to content

[ADL/TGL/MTL NOCODEC] Frequency response is different between left and right channel #7184

Closed

Description

@fredoh9

Found alsabat failure with ADLP_RVP_NOCODEC_IPC4ZPH.
https://sof-ci.01.org/linuxpr/PR4212/build3371/devicetest/index.html?model=ADLP_RVP_NOCODEC_IPC4ZPH&testcase=check-alsabat-headset-playback

  • Kernel PR: 4212
  • SOF Branch: main
  • SOF Commit: a74ad93
  • Zephyr Commit: zephyr-v3.3.0-200-g9af2789cad17
  • tplg: sof-adl-nocodec.tplg

sof-adl-nocodec

alsabat test only complains about right channel.

BAT analysis: signal has 65536 frames at 48000 Hz, 2 channels, 2 bytes per sample.

Channel 1 - Checking for target frequency 821.00 Hz
Amplitude: 31128.9; Percentage: [95]
Detected peak at 821.04 Hz of 41.56 dB
 Total 42.4 dB from 818.85 to 823.24 Hz
 PASS: Peak detected at target frequency
Detected at least 1 signal(s) in total

Channel 2 - Checking for target frequency 821.00 Hz
Amplitude: 30990.5; Percentage: [94]
Detected peak at 815.92 Hz of 20.72 dB
 Total 20.7 dB from 815.92 to 815.92 Hz
Detected peak at 821.04 Hz of 38.11 dB
 Total 39.5 dB from 817.38 to 822.51 Hz
 PASS: Peak detected at target frequency
Detected peak at 823.97 Hz of 20.52 dB
 Total 39.5 dB from 823.97 to 823.97 Hz
 PASS: Peak detected at target frequency
Detected at least 3 signal(s) in total

Return value is -1003

Attached: ADLP_RVP_NOCODEC_alsabat_wav_captured.zip

  • bat.wav.9LAB5b ; alsabat test output
  • left.wav ; only left channel
  • right.wav ; only right channel-

Left and Right channels are separated. Did frequency analysis.
left_fa_20230223_190923
right_fa_20230223_190930

One caveat is I couldn't reproduce this manually with same device.

Activity

  1. fredoh9 commented on Feb 24, 2023

    @fredoh9
    ContributorAuthor

    Found same failure with different pr test on different device.
    Intel internal test: planresultdetail/21323?model=ADLP_RVP_NOCODEC_IPC4ZPH&testcase=check-alsabat-headset-playback

    • Kernel PR: 4210
    • SOF Branch: main
    • SOF Commit: a74ad93
    • Zephyr Commit: zephyr-v3.3.0-200-g9af2789cad17
  2. changed the title [-]Frequency response is different between left and right channel[/-] [+][ADLP_RVP_NOCODEC_IPC4ZPH] Frequency response is different between left and right channel[/+] on Feb 24, 2023
  3. added
    ADLApplies to Alder Lake platform
    on Feb 24, 2023
  4. fredoh9 commented on Feb 24, 2023

    @fredoh9
    ContributorAuthor

    I scanned through TGLU_RVP_NOCODEC_IPC4ZPH test result and found same failure.
    Intel internal test: planresultdetail/21269?model=TGLU_RVP_NOCODEC_IPC4ZPH&testcase=check-alsabat-headset-playback

    Now this is more making sense.

  5. changed the title [-][ADLP_RVP_NOCODEC_IPC4ZPH] Frequency response is different between left and right channel[/-] [+][ADL/TGL NOCODEC] Frequency response is different between left and right channel[/+] on Feb 24, 2023
  6. juimonen commented on Feb 24, 2023

    @juimonen

    actually got the same with link clock fix PR on mtl: https://sof-ci.ostc.intel.com/#/result/planresultdetail/21290

    Like the channels are "mis-aligned" and right channel has gaps (also left, but much less).

  7. added
    P1Blocker bugs or important features
    on Feb 28, 2023
  8. changed the title [-][ADL/TGL NOCODEC] Frequency response is different between left and right channel[/-] [+][ADL/TGL/MTL NOCODEC] Frequency response is different between left and right channel[/+] on Feb 28, 2023
  9. juimonen commented on Feb 28, 2023

    @juimonen

    tried to reproduce with tgl, but just could not....

  10. singalsu commented on Feb 28, 2023

    @singalsu
    Collaborator

    There's a glitch in the second channel at about 0.466s time:

    Screenshot from 2023-02-28 11-25-10

  11. singalsu commented on Feb 28, 2023

    @singalsu
    Collaborator

    One sample is from 1ms ago:

    Screenshot from 2023-02-28 11-28-23

    Screenshot from 2023-02-28 11-27-36

  12. juimonen commented on Feb 28, 2023

    @juimonen

    yeah, so there is the phase difference from smart amp between channels, but also some "gaps/peaks" in the channels. I think I actually also spotted them also in the left channel, but much more rarely than right channel. So I suspect something is fishy with buffer copy, somewhere.

  13. ranj063 commented on Feb 28, 2023

    @ranj063
    Collaborator

    @aiChaoSONG can you please look into this?

  14. lgirdwood commented on Mar 2, 2023

    @lgirdwood
    Member

    Unlikely DMA as glitch would happen on both channels at the same time. Is SSP loopback mode used here ? SSP reads one word in FIFO at a time.

  15. juimonen commented on Mar 8, 2023

    @juimonen

    I tried with mtl device and ssp1 and ssp2 are clean with the alsabat test. This has to be something to do with the complex pipeline with smart amp feedback.

  16. added a commit that references this issue on Apr 4, 2023
    e000585
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

ADLApplies to Alder Lake platformP1Blocker bugs or important featuresTGLApplies to Tiger Lake

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions