Repository navigation
[BUG] build-tools.sh fails after merging 3064 #3165
Description
Describe the bug
build-tools.sh fails to build topology parser.
To Reproduce
Just call ./scripts/build-tools.sh
Reproduction Rate
100%
Expected behavior
./scripts/build-tools.sh build all tools successfully.
Environment
- Branch name and commit hash of the 2 repositories: sof (firmware/topology) and linux (kernel driver).
- Kernel: n/a
- SOF: 318dc9f
- Name of the topology file
- Topology: n/a
- Name of the platform(s) on which the bug is observed.
- Platform: n/a
Screenshots or console output
50%] Building C object CMakeFiles/sof_tplg_parser.dir/tplg_parser.c.o In file included from /home/admin/Dev/fork/sof/tools/tplg_parser/tplg_parser.c:20:0: /home/admin/Dev/fork/sof/tools/tplg_parser/include/tplg_parser/topology.h:13:10: fatal error: sound/asoc.h: No such file or directory #include <sound/asoc.h> ^~~~~~~~~~~~~~ compilation terminated.
Activity
mrajwa commentedon Jul 12, 2020
This is because #3064 adds fuzzer as a default build and fuzzer depends on tplg_parser.c which has never been built before. This file tplg_parser.c has compilation problems due to missing library, namely asoc.h. I am adding it here #3166
lgirdwood commentedon Jul 14, 2020
@jajanusz I assume we have a cmake variable that points to the kernel header path ? This needs to be used here too.
jajanusz commentedon Jul 14, 2020
No we don't have. These headers are usually in 'system headers path' so they are picked up be compiler without specyfing include dirs (fe. when you install linux headers with apt-get). Probably that's why it worked for everyone that was using it in the past - the headers were there, and also are there on CI.
If you don't know what package to install and just want to add include dirs locally, you can do something like
CFLAGS=-I/path/to/folder/with/sound/soc cmake -Detcetc ....lgirdwood commentedon Jul 14, 2020
@mrajwa the package to install is usually called linux-headers. I wonder if this package is missing from install guide ?
jajanusz commentedon Jul 14, 2020
I haven't seen it in install guide.
marc-hb commentedon Jul 16, 2020
I think it's there, see #3166 (comment)
Cc: @crazoes