You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
cmocka ut: Unit tests should be uniquely identifiable by function names #153
We have to use naming like we were using with first unit test (f.e. list, audio buffer) - name of the testing function should go like test__, like test_math_numbers_gcd_when_something_then_something, otherwise we will have in TAP logs on CIs logs like:
For files:
someheaderA\a.c
someheaderB\a.c
TAP output will look like
PASS: a - a_test_condition
FAIL: a - a_test_condition
And we don't know for which one it failed.
So please make your test names more verbose.
@jajanusz can you align with the local authors and ask them to send incremental fixes. I'll also check this now on UT patches. Btw, who should also be checking and approving all UT patches ?
Activity
lgirdwood commentedon Jul 26, 2018
@jajanusz can you align with the local authors and ask them to send incremental fixes. I'll also check this now on UT patches. Btw, who should also be checking and approving all UT patches ?
jajanusz commentedon Jul 26, 2018
@lgirdwood I asked them already to fix names. You can assign me to all UT patches.
slawblauciak commentedon Jul 26, 2018
Fixed in #155