Skip to content

cmocka ut: Unit tests should be uniquely identifiable by function names #153

Closed

Description

@jajanusz

We have to use naming like we were using with first unit test (f.e. list, audio buffer) - name of the testing function should go like test__, like test_math_numbers_gcd_when_something_then_something, otherwise we will have in TAP logs on CIs logs like:
For files:

someheaderA\a.c
someheaderB\a.c

TAP output will look like

PASS: a - a_test_condition
FAIL: a - a_test_condition

And we don't know for which one it failed.
So please make your test names more verbose.

Activity

  1. lgirdwood commented on Jul 26, 2018

    @lgirdwood
    Member

    @jajanusz can you align with the local authors and ask them to send incremental fixes. I'll also check this now on UT patches. Btw, who should also be checking and approving all UT patches ?

  2. jajanusz commented on Jul 26, 2018

    @jajanusz
    ContributorAuthor

    @lgirdwood I asked them already to fix names. You can assign me to all UT patches.

  3. slawblauciak commented on Jul 26, 2018

    @slawblauciak
    Collaborator

    Fixed in #155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions