Skip to content

case-lib: add an option to control fallback behavior #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aiChaoSONG merged 1 commit into from
May 31, 2022
Merged

case-lib: add an option to control fallback behavior #914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions case-lib/config.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,3 +70,14 @@ SUDO_LEVEL=${SUDO_LEVEL:-}
# waited by the internal test runner used by sof/jenkins CI and that
# test runner does not define SOF_TEST_INTERVAL (internal bug 158)
SOF_TEST_INTERVAL=${SOF_TEST_INTERVAL:-5}

# If we don't have SOF card in the system in SOF test, the default fallback
# to test pipelines from /proc behavior will cause false positive, because
# we are testing USB sound card or Nvidia HDMI under this condition.
#
# This option is used to control the fallback behavior. It should be set
# to 'false' for SOF test, and set to 'true' for legacy HDA test.
#
# Refer to: https://github.com/thesofproject/sof-test/issues/471 and
# https://github.com/thesofproject/sof-test/issues/913 for more information.
FALLBACK_TO_PROC=${FALLBACK_TO_PROC:-false}
3 changes: 3 additions & 0 deletions case-lib/pipeline.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ func_pipeline_export()
# For legacy HDA platform, there is no topology, we have to export pipeline
# parameters from proc file system.
is_sof_used || {
[ "$FALLBACK_TO_PROC" == "true" ] ||
die "No SOF sound card found and fallback mode disabled, failing."

filter_str="$2"
dlogi "No SOF sound card found, exporting pipeline parameters from proc file system"
tmp_pipeline_params=$(mktemp /tmp/pipeline-params.XXXXXXXX)
Expand Down