Skip to content

sof-dump-status: add TGL-H audio PCI ID - #428

Merged
xiulipan merged 1 commit into
thesofproject:masterfrom
aiChaoSONG:tglh_pci
Oct 15, 2020
Merged

xiulipan merged 1 commit into
thesofproject:masterfrom
aiChaoSONG:tglh_pci

Conversation

@aiChaoSONG

Copy link
Copy Markdown

This patch keeps PCI ids in sof-dump-status.py and https://github.com/thesofproject/linux/blob/topic/sof-dev/sound/soc/sof/sof-pci-dev.c aligned

@aiChaoSONG
aiChaoSONG requested a review from a team as a code owner October 12, 2020 08:58
@marc-hb

marc-hb commented Oct 13, 2020

Copy link
Copy Markdown
Collaborator

BSW_CYN_MAX98090 failed to boot in https://sof-ci.01.org/softestpr/PR428/build250/devicetest

I believe jf-bsw-cyn-max98090-6 has been having eMMC issues, see for instance https://sof-ci.01.org/softestpr/PR410/build251/devicetest/

Unfortunately https://sof-ci.01.org/softestpr/PR428/build250/devicetest/ does not give the device hostname.

@aiChaoSONG can we disable this device for the moment?

@aiChaoSONG

Copy link
Copy Markdown
Author

@marc-hb I think jf-bsw-cyn-98090-3 also has eMMC issue, as you can check from CI issue 539. We have 4 bsw-cyn devices with ID 3,4,5,6. if we disable 3 and 6, I am not sure two devices are enough for PR and daily test, let's involve more people.
@mengdonglin @xiulipan

@marc-hb

marc-hb commented Oct 13, 2020

Copy link
Copy Markdown
Collaborator

This is getting more confusing every day. https://github.com/thesofproject/sof/pull/3451/files has tgplp and tgph, https://github.com/thesofproject/linux/blob/topic/sof-dev/sound/soc/sof/sof-pci-dev.c has sof-tgl-h.ri. Now this python script has tglh.

@lgirdwood , @plbossart , @jajanusz , can we please fix P1 documentation issue thesofproject/sof#3491 yesterday?

Signed-off-by: Amery Song <chao.song@intel.com>
@aiChaoSONG

Copy link
Copy Markdown
Author

@marc-hb this python script should keep accordance with the kernel, and the name should be tgl-h.

@marc-hb

marc-hb commented Oct 15, 2020

Copy link
Copy Markdown
Collaborator

@marc-hb this python script should keep accordance with the kernel

Do you mean: "... with the .ri filename in /lib/firmware/intel/"?

@aiChaoSONG

Copy link
Copy Markdown
Author

@marc-hb this python script should keep accordance with the kernel

Do you mean: "... with the .ri filename in /lib/firmware/intel/"?

You can understand like this. If we run sof-dump-status.py -p to get platform name, like you do in sof-kernel-log-check, we will first acquire PCI ID, and get platform name by PCI ID, and this is the dict we use to do the mapping. and the platform name appears in the FW filename, sof-PLATFORM.ri

@xiulipan xiulipan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xiulipan
xiulipan merged commit 6b4000f into thesofproject:master Oct 15, 2020
@aiChaoSONG
aiChaoSONG deleted the tglh_pci branch October 24, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants