Repository navigation
check-ipc-flood.sh: stop asking Zephyr users to use CONFIG_DEBUG - #1227
Merged
Merged
Conversation
Collaborator
Author
|
Better SKIP message: https://sof-ci.01.org/softestpr/PR1227/build719/devicetest/index.html?model=LNLM_RVP_NOCODEC&testcase=check-ipc-flood Usual LNL failures, everything else green. Good to go. |
Add is_ipc4() call and a new SKIP message to stop telling Zephyr users to build a "debug firmware" because it won't change anything for them: IPC4 has no flood command right now, see thesofproject#1066 Also clarify the XTOS skip message + other cosmetic improvements. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
force-pushed
the
ipc-flood-reason
branch
from
August 13, 2024 22:04
8522597 to
ecbde31
Compare
fredoh9
approved these changes
Aug 13, 2024
fredoh9
left a comment
fredoh9
left a comment
Contributor
There was a problem hiding this comment.
Looks clear than before!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add is_firmware_file_zephyr() and a new SKIP message to stop telling Zephyr users to build a "debug firmware" because it won't change anything for them: IPC4 has no flood command right now, see #1066
Also clarify the XTOS skip message + other cosmetic improvements.