Repository navigation
verify-kernel-log.sh: guard "xrandr" with a short "timeout" - #1200
Merged
Merged
Conversation
xrandr can hang! Who could have known? See evidence in: thesofproject/linux#5009 (comment) Don't wait for CI to timeout and kill the whole script so we don't lose precious logs. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
ujfalusi
approved these changes
May 23, 2024
ujfalusi
left a comment
ujfalusi
left a comment
Contributor
There was a problem hiding this comment.
Hrm, how does it locks up? anything in dmesg?
What else is going to be broken when xrandr hangs? Is it safe to test display audio for example?
Collaborator
Author
|
Thanks for the review!
There was nothing specific to xrandr but there were some i915 and drm errors, see my comments in thesofproject/linux#5009 (comment) I think they were related. The main issue is: I had to use ssh to get these logs - because xrandr hung we were deprived of published logs = what this PR will hopefully fix.
It looks like the rest of the test in that linux PR passed but who knows - exactly why we need logs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xrandr can hang! Who could have known? See evidence in:
Don't wait for CI to timeout and kill the whole script so we don't lose precious logs.