Repository navigation
check-signal-stop-start.sh: report failure when process terminated early - #1000
Conversation
d9266f6 to
d561f1d
Compare
marc-hb
left a comment
marc-hb
left a comment
There was a problem hiding this comment.
Please fix the shellcheck errors first so a quick revert is easy if needed.
marc-hb
left a comment
marc-hb
left a comment
There was a problem hiding this comment.
Good catch BTW: so this test has provided the "ultimate green failure" for many years?
marc-hb
added
False Pass / green failure
P1
d561f1d to
9611572
Compare
| source "$(dirname "${BASH_SOURCE[0]}")"/../case-lib/lib.sh | ||
|
|
||
| OPT_NAME['t']='tplg' OPT_DESC['t']='tplg file, default value is env TPLG: $TPLG' | ||
| OPT_NAME['t']='tplg' OPT_DESC['t']="tplg file, default value is env TPLG: $TPLG" |
There was a problem hiding this comment.
-h already shows the default value (please try changed code) so you can drop the last $TPLG bit. As a bonus it will fix one more shellcheck warning (please run shellcheck -x locally)
Fixed shellcheck error, no function changed. Signed-off-by: Fred Oh <fred.oh@linux.intel.com>
When aplay or arecord process is terminated during the test, while loop condition catches the error first then just return the function. In this case it ends up with a false pass. Removed the process check from while loop. sof-process-state.sh will do it anyway. issue link: thesofproject#988 Signed-off-by: Fred Oh <fred.oh@linux.intel.com>
9611572 to
153ee2b
Compare
Yes, sadly this has given us false positive for years. |
| # shellcheck source=case-lib/lib.sh | ||
| source "$(dirname "${BASH_SOURCE[0]}")"/../case-lib/lib.sh | ||
|
|
||
| OPT_NAME['t']='tplg' OPT_DESC['t']='tplg file, default value is env TPLG' |
There was a problem hiding this comment.
So this no longer shows the value of $TPLG?
There was a problem hiding this comment.
So this no longer shows the value of $TPLG?
It does; I just "unresolved" the comment above that explains this. Try -h.
| dlogi "Testing: run stop/start test on PCM:$pcm,$pipeline_type. Interval time: $interval" | ||
| dlogc "$cmd -D$dev -r $rate -c $channel -f $fmt $dummy_file -q &" | ||
| $cmd -D$dev -r $rate -c $channel -f $fmt $dummy_file -q & | ||
| $cmd -D"$dev" -r "$rate" -c "$channel" -f "$fmt" $dummy_file -q & |
There was a problem hiding this comment.
Shellcheck didn't care about $dummy_file?
There was a problem hiding this comment.
shellcheck seems smart enough to find "local" variables and make sure they don't include any problematic character.
|
I'd like to merge this before the daily build/test today |
When aplay or arecord process is terminated during the test, while loop condition catches the error first then just return the function. In this case it ends up with a false pass.
Removed the process check from while loop. sof-process-state.sh will do it anyway.
issue link: #988
Signed-off-by: Fred Oh fred.oh@linux.intel.com