Skip to content

Add sections on Intel ME dependency - #304

Merged
deb-intel merged 3 commits into
thesofproject:masterfrom
plbossart:fix/intel-me
Jan 25, 2021
Merged

deb-intel merged 3 commits into
thesofproject:masterfrom
plbossart:fix/intel-me

Conversation

@plbossart

Copy link
Copy Markdown
Member

No description provided.


ls /dev/mei*/

If no devices are reported, then the user needs to enable the ME.

@marc-hb marc-hb Oct 27, 2020 •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted by @fredoh9 , maybe mention here that /dev/mei*/ requires some Kconfig in the first place.

Also mention that firmware authentication itself does NOT require any /dev/mei*/, which could be confusing. Calling `/dev/mei*/ a "debug interface" should avoid this confusion even though it's not just a debug interface.

@plbossart

Copy link
Copy Markdown
Member Author

please don't merge for now, the part on /dev/mei is likely to require a significant update.

@marc-hb
marc-hb marked this pull request as draft October 28, 2020 23:01

@lgirdwood lgirdwood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is useful info.

Git is not happy without it

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
@plbossart

Copy link
Copy Markdown
Member Author

updated (no way to detect ME enablement) and added section on HDaudio amps.

@plbossart
plbossart marked this pull request as ready for review January 19, 2021 22:29
capabilities, codec names, and DMI options. While the SOF team and the
community try to cover all possible cases, errors will happen when the
wrong file is selected at any of the three layers. No newline at end of file
wrong file is selected at any of the three layers.

@marc-hb marc-hb Jan 19, 2021 •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange, I've seen github display missing new lines much better than this before.

I've been puzzled by this misleading "zero diff" until I looked at the commit message so leaving a comment for others.


The Intel ME (Management Engine) is responsible for authentication of
the firmware, be it signed by an Intel production key, a community key
or an OEM key. If the Intel ME is disabled by an OEM, or disabled by

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

..., be it signed by an Intel or OEM production key (consumer products) or by a community key (development systems and make boards)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chromebooks also use community key.

If the ME is disabled by the OEM or the user, firmware authentication
will fail without an explicit log provided to the user. In case of any
authentication failure, the user should verify that the ME is not
disabled.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

..., more information about the ME in the "firmware binary" section above.

***************************

If the ME is disabled by the OEM or the user, firmware authentication
will fail without an explicit log provided to the user. In case of any

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without any explicit feedback provided to the user

(more generic)

@lgirdwood lgirdwood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deb-intel are you able to fix up the grammar after merge as you usually do ? @marc-hb has pointed out a few grammar changes., but there maybe others. Need to merge for v1.7

@deb-intel

Copy link
Copy Markdown
Collaborator

@lgirdwood, yes, I can make merged grammatical updates.

This was missed in earlier patches and a key dependency

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Inspired by https://bugzilla.kernel.org/show_bug.cgi?id=210633

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
@plbossart

Copy link
Copy Markdown
Member Author

pushed changes suggested by @marc-hb

@deb-intel deb-intel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will make grammatical updates in a separate PR.

@deb-intel
deb-intel merged commit e5abdaa into thesofproject:master Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants