Repository navigation
v2.2.2 - #98
v2.2.2#98
Conversation
|
@lgirdwood Can you help invite Mark @mrhpearson to this repo? He will integrate sof-bin releases to Debian. I hope to add him as a reviewer for the release PRs. Thanks! |
This means version 2.2 will appear in logs, correct? |
@marc-hb. Correct. FW will report version v2.2 to kernel driver after booting the DSP and so v2.2 will appear in dmesg. The FW binaries are built from SOF tag v2.2 (https://github.com/thesofproject/sof/releases/tag/v2.2), and we don't rebuild any FW binaries. |
There was a problem hiding this comment.
In that case I don't think it's a good idea to duplicate so many files in git.
I just tested my new script (submitted in #91) that can combine multiple versions and I can create the same final tarball without so much duplication in git; only in the tarball.
Like this:
./tarball_multi_releases.bash v2.2.x/sof-v2.2 v2.2.x/tools-v2.2 \
v2.2.x/sof-tplg-v2.2.2/ v2.2.x/sof-v2.2.2-with-new-stuff-only
v2.2.x/sof-v2.2.2-with-new-stuff-only does not exist yet, it would have to be submitted first and it should of course be named v2.2.x/sof-v2.2.2. It would 1% the size of this PR.
|
Also, |
|
Looks good to me - thanks! |
|
@marc-hb @mrhpearson @perexg @keqiaozhang I tried Marc's idea to reduce copies of identical FW, topology and tool binaries. It works well for me. So I updated the PR. Can you please give a review again? Major changes: All other Intel released platforms can stay with v2.2 FW binaries, The latest version of sof tools is v2.2. To combine v2.2 FW binaries, v2.2 sof tools, v2.2.1 topology, and A tar ball will be generated to include all the binaries with a |
|
Thanks again @mengdonglin for the instant testing, so much teamwork across timezones is exhilarating :-) https://github.com/thesofproject/sof-bin/actions/runs/3061834845/jobs/4942097194 is failing because you're removing the In general we should never remove files that have been released but there are always exceptions and this one makes sense to me. You can very easily make this test pass again (TESTED!) if you rebase after my brand new #100 is merged. |
I downloaded this PR, ran @mengdonglin's command and here's a slightly shorten version of this manifest.txt found in the tarball. Note this is NOT the content of the tarball! This is the manifest.txt file inside it. |
This is confusing. I think I know why my new script forced you to do that and I just submitted a (TESTED!) one-line fix in brand new With #101 it should be possible to remove all duplication from this PR. |
|
Totally different topic: I think we should get rid of the |
|
@marc-hb @mrhpearson @perexg @keqiaozhang @lgirdwood I updated the PR to v3. Can you please review? We also need Marc's PR #100 and #101 to be merged at first. #100 can fix PR check error. #101 can fix script complaining about broken symbolic links when generating the combined tar ball. Major changes:
|
@marc-hb Rebased and uncomment |
|
OK - I think I get it. Still find it a little strange to be honest...but it will make more sense once I get the packaging side figured out |
|
Hey! |
@vincentbernat Thanks for feedback! I think you will integrate SOF into Ubuntu, right? @perexg Are you also good with this plan? |
|
I just help @mrhpearson on the Debian packaging. @LocutusOfBorg is the last one who did an upload for Ubuntu, based on the Debian package. |
|
Just to be extra sure: will tarballs for future release always contain both sof-tplg and sof directories, unlike what has been done for 2.2 and 2.2.1? |
@vincentbernat Yes, the tarball will always contain both sof-tplg and sof directories for future releases. We'll clarify how the tarball is generated in the release notes. If users are not satisfied with the default tarball, they can use the scripts to generate their own tarball(s). |
|
Hello, in Ubuntu we have a delta for this package why aren't such files upstream? https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1966841 |
|
or aren't them needed anymore with new release? |
|
Looks like a miss @LocutusOfBorg, this file is part of the mainline and was likely missed in the backport to 2.2. It's definitively needed by some Dell SKUs without local microphones. From the CMakeLists.txt: @mengdonglin @marc-hb FYI. |
|
Actually this file is correctly shown in the backported v2.2.2, so not sure how it can be missing from the release binary? I also see it in 2.2.1, |
@LocutusOfBorg @plbossart This topology binary file is in v2.2.1 https://github.com/thesofproject/sof-bin/blob/main/v2.2.x/sof-tplg-v2.2.1/sof-adl-rt711-l2-rt1316-l01.tplg This v2.2.2 PR doesn't include any topology binaries itself. But after this v2.2.2 PR is merged, we can combine v2.2 FW, v2.2.1 topology and v2.2.2 FW updates for RPL by running It will generate a tarball 'sof-bin-v2.2.2.tar.gz'. Extract it to Is it good to you? |
|
as long as it works, its good for me :) |
|
@mengdonglin @marc-hb still draft - are we blocking on #102 ? |
@lgirdwood @marc-hb tested with PR #102. I rebased this PR with latest main. I think this PR is good for merge. Marc plans to add a couple of tests for install.sh tomorrow. We can wait for these tests are also merged and then apply tag v2.2.2 and upload t the tarball. |
Topology v2 binaries cavs*.tplg are removed because they're not for v2.2.x releases and not used by any released products. Signed-off-by: mengdonglin <mengdong.lin@intel.com>
Add firmware symbolic links for Intel Raptor Lake (RPL) platform. RPL has the same community signed binaries as TGL, and same Intel- signed binaries as ADL, because - TGL/ADL/RPL share the same audio IP and community signature; - ADL and RPL also share the same production signature, but different from TGL. Create new folder sof-v2.2.2 and create new symbolic links for RPL. They point to v2.2 TGL and ADL FW binaries. sof-v2.2.2/ ├── community │ ├── sof-rpl.ri -> sof-tgl.ri │ └── sof-rpl-s.ri -> sof-tgl-h.ri ├── intel-signed │ ├── sof-rpl.ri -> sof-adl.ri │ └── sof-rpl-s.ri -> sof-adl-s.ri ├── sof-rpl.ldc -> sof-tgl.ldc ├── sof-rpl.ri -> intel-signed/sof-rpl.ri ├── sof-rpl-s.ldc -> sof-tgl-h.ldc └── sof-rpl-s.ri -> intel-signed/sof-rpl-s.ri sof-v2.2.2 needs to be combined with sof-v2.2 to get FW binaries for all Intel released platforms. All other Intel platforms can stay with v2.2 FW binaries, because there are no FW source code or binary updates from v2.2 The latest version of sof tools is v2.2 The latest version of topology is v2.2.1 To generate a tar ball to include latest binaries of FW, tool and topology binaries for all Intel released platforms, please combine v2.2 FW binaries, v2.2 sof tools, v2.2.1 topology, and this v2.2.2 FW updates for RPL: $ ./tarball_multi_releases.bash v2.2.x/sof-v2.2 v2.2.x/tools-v2.2 \ v2.2.x/sof-tplg-v2.2.1/ v2.2.x/sof-v2.2.2 The manifest file in the tar ball can show source version of each file and symbolic link. Signed-off-by: mengdonglin <mengdong.lin@intel.com>
For shell completion convenience. Signed-off-by: mengdonglin <mengdong.lin@intel.com>
The symbolic links are not needed to generate the sof-bin tar ball. And install.sh in the tar ball will create the 2 symbolic links in /lib/firmware/intel automatically. Signed-off-by: mengdonglin <mengdong.lin@intel.com>
cavs*.tplg are topology v2 files that are not used by any Intel released platforms atm. They should not be included in v2.2.x releases. Signed-off-by: mengdonglin <mengdong.lin@intel.com>
No need to wait for these tests. |
@marc-hb okay. Then I'll apply tag v2.2.2 to sof-bin and upload tarball once this PR gets merged. |
|
@lgirdwood Thank you! @marc-hb @mrhpearson @vincentbernat @LocutusOfBorg @perexg v2.2.2 is done and tarball is uploaded: https://github.com/thesofproject/sof-bin/releases/tag/v2.2.2 Please file a bug if you see any issues with this release. Thank you! |
|
@mengdonglin : The binary file is not a part of the assets like in the previous releases. The URL https://github.com/thesofproject/sof-bin/releases/download/v2.2.2/sof-bin-v2.2.2.tar.gz does not work (comparing to https://github.com/thesofproject/sof-bin/releases/download/v2.1.1/sof-bin-v2.1.1.tar.gz). |
|
Thx @perexg , I'm looking into that. In the mean time could try the https://github.com/thesofproject/sof-bin/files/9632845/sof-bin-v2.2.2.tar.gz link that can be found slightly above in the page? |
|
The tar ball works (seem ok locally), but I'd like to have a valid source URL before the update of my Fedora / RHEL packages. RPM spec code: |
|
Should be fixed now, sorry for the delay. |
|
@marc-hb Thank you! |
|
Just as an FYI update - the Debian method has been updated to use the tarballs now; and the 2.2.2 package is prepared for release (hopefully goof free). |
Updated for the latest version:
v2.2.2 is to add support for Intel Raptor Lake (RPL) platform.
It's a full release with FW, topology and tool binaries for all released platforms.RPL has the same community signed binaries as TGL, and same Intel-
signed binaries as ADL, because
from TGL.
Create new folder sof-v2.2.2 and create new symbolic links for RPL.
They point to v2.2 TGL and ADL FW binaries.
sof-v2.2.2 needs to be combined with sof-v2.2 to get FW binaries for
all Intel released platforms. All other Intel platforms can stay
with v2.2 FW binaries, because there are no FW source code or binary
updates from v2.2
The latest version of sof tools is v2.2
The latest version of topology is v2.2.1
To generate a tar ball to include latest binaries of FW, tool and
topology binaries for all Intel released platforms, please combine
v2.2 FW binaries, v2.2 sof tools, v2.2.1 topology, and this v2.2.2 FW
updates for RPL:
The manifest file in the tar ball can show source version of each
file and symbolic link.
cc: