Skip to content

ASoC: SOF: ABI unify for KeyWordDetect - #857

Closed
xiulipan wants to merge 1 commit into
thesofproject:topic/sof-devfrom
xiulipan:pr/abi36
Closed

xiulipan wants to merge 1 commit into
thesofproject:topic/sof-devfrom
xiulipan:pr/abi36

Conversation

@xiulipan

Copy link
Copy Markdown

After a few patches related to keyworddetect, there is a few gap between
ABI and header between Linux and SOF FW.

Signed-off-by: Pan Xiuli xiuli.pan@linux.intel.com

Fix the SOF ABI bump from thesofproject/sof#1036

@xiulipan xiulipan added the ABI involves ABI changes, need extra attention label Apr 22, 2019
After a few patches related to keyworddetect, there is a few gap between
ABI and header between Linux and SOF FW.

Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
@plbossart

Copy link
Copy Markdown
Member

@lgirdwood that makes 2 PRs in one day where we have to review the ABI changes... I have no idea how this might be used by a kernel given that there are no matching topology tokens.

@ranj063

ranj063 commented Apr 23, 2019

Copy link
Copy Markdown
Collaborator

@xiulipan @plbossart I dont think this is necessary in the kernel. the config data is set via binary blob that is attached to the bytes kcontrol

@plbossart

Copy link
Copy Markdown
Member

@xiulipan @plbossart I dont think this is necessary in the kernel. the config data is set via binary blob that is attached to the bytes kcontrol

why is it described as part of the firmware then? if it's not an ABI there is no reason for this file to exist.

@ranj063

ranj063 commented Apr 23, 2019

Copy link
Copy Markdown
Collaborator

@xiulipan @plbossart I dont think this is necessary in the kernel. the config data is set via binary blob that is attached to the bytes kcontrol

why is it described as part of the firmware then? if it's not an ABI there is no reason for this file to exist.

@plbossart this header file shouldnt be in the uapi folder in the FW. It should be moved to the src/audio folder. let me check with slawomir about it

@keyonjie

keyonjie commented Apr 25, 2019 •

Copy link
Copy Markdown

@xiulipan we don't need this struct definition in driver side.

We have header gap b/w FW & driver at the moment, I am sending PRs(thesofproject/sof#1304, #864) to align those definitions(actually it's already newer in driver).

After those gaps are filled, only a simple driver version bump to 3.6 is needed:
c48713b

@xiulipan

Copy link
Copy Markdown
Author

@keyonjie
I will close this PR. Could you just handle the ABI version of 3.6.0 align within the keyword detect header alignment.

@xiulipan xiulipan closed this Apr 25, 2019
@keyonjie

Copy link
Copy Markdown

@xiulipan sure, doing it now.

@xiulipan
xiulipan deleted the pr/abi36 branch May 15, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ABI involves ABI changes, need extra attention

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants