Repository navigation
Conversation
The following functions are only used internally, they don't need to be exported: hda_cl_copy_fw(), hda_cl_prepare(), hda_cl_trigger() and hda_cl_cleanup(). Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
While on first boot we obviously not going to do an IMR boot as we have not booted the DSP up yet, but the flag can be evaluated earlier to allow new features to rely on the IMR support flag. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
…download It has been reported that the DMA memory allocation for firmware download can fail after extended period of uptime on systems with relatively small amount of RAM when the system memory becomes fragmented. The issue primarily happens when the system is waking up from system suspend, swap might not be available and the MM system cannot move things around to allow for successful allocation. If the IMR boot is not supported then for each DSP boot we would need to allocate the DMA buffer for firmware transfer, which can increase the chances of the issue to be hit. This patch adds support for allocating the DMA buffer once at first boot time and keep it until the system is shut down, rebooted or the drivers re-loaded. In case IMR boot is not supported, always cache the DMA memory and a module parameter is provided to force this behavior if needed. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
marc-hb
force-pushed
the
testjenkins607
branch
from
September 20, 2024 16:52
9c76e97 to
b081c9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-test jenkins failure #5182 (comment) / internal issue 607
…download
It has been reported that the DMA memory allocation for firmware download can fail after extended period of uptime on systems with relatively small amount of RAM when the system memory becomes fragmented.
The issue primarily happens when the system is waking up from system suspend, swap might not be available and the MM system cannot move things around to allow for successful allocation.
If the IMR boot is not supported then for each DSP boot we would need to allocate the DMA buffer for firmware transfer, which can increase the chances of the issue to be hit.
This patch adds support for allocating the DMA buffer once at first boot time and keep it until the system is shut down, rebooted or the drivers re-loaded and makes this as the default operation.
With keep_firmware_dma_buffer module parameter the persistent firmware download DMA buffer can be disabled to fall back to on demand allocation.