Repository navigation
Conversation
We will disable SDW interrupt in hda_sdw_exit() before sdw_intel_exit() and peripherals will on longer access SDW registers. However, when the manager became pm_runtime active in the remove procedure, peripherals will be attach, and do the initialization process. The commit suggests a sdw_intel_pre_exit() function to disable peripherals runtime pm and wait for peripherals to being initialized. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
plbossart
reviewed
Mar 6, 2024
| return 0; | ||
| } | ||
|
|
||
| pm_runtime_disable(dev); |
Member
There was a problem hiding this comment.
I think this is conceptually broken.
pm_runtime_disable() only means that the device can no longer enter pm_runtime suspend. It doesn't do what is suggested in the commit message "wait for peripherals to being initialized"
In addition, if something else tries to do a pm_runtime_get_sync() or pm_runtime_resume(), an error code -EACCESS will be thrown.
We should only use pm_runtime_disable() in the .remove functions or AFTER resuming the devices fully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We will disable SDW interrupt in hda_sdw_exit() before sdw_intel_exit() and peripherals will on longer access SDW registers. However, when the manager became pm_runtime active in the remove procedure, peripherals will be attach, and do the initialization process. The commit suggests a sdw_intel_pre_exit() function to disable peripherals runtime pm and wait for peripherals to being initialized.