Repository navigation
Fix delay error - #4791
Closed
RanderWang wants to merge 1 commit into
Closed
Fix delay error#4791RanderWang wants to merge 1 commit into
RanderWang wants to merge 1 commit into
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we use runtime->hw_ptr and BE dai link position to calculate
delay and find runtime->hw_ptr is smaller than BE dai link position for
playback. This is incorrect since snd_pcm_delay function is called
first and then hw_ptr is updated to latest one, so hw_ptr here is for
the last stream position update. This results to hw_ptr is smaller than
latest BE dai link position. This bug is exposed by a 10 microseconds
delay in fw.
#4781
#4686