Skip to content

ASoC: Intel: soc-acpi: fix copy-paste issue in topology names - #4115

Merged
plbossart merged 1 commit into
thesofproject:topic/sof-devfrom
plbossart:fix/adl-es8336
Jan 3, 2023
Merged

plbossart merged 1 commit into
thesofproject:topic/sof-devfrom
plbossart:fix/adl-es8336

Conversation

@plbossart

Copy link
Copy Markdown
Member

For some reason the convention for topology names was not followed and the name inspired by another unrelated hardware configuration. As a result, the kernel will request a non-existent topology file.

Link: thesofproject/sof#6878
Fixes: 2ec8b08 ("ASoC: Intel: soc-acpi: Add entry for sof_es8336 in ADL match table")
Cc: stable@vger.kernel.org
Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com

For some reason the convention for topology names was not followed and
the name inspired by another unrelated hardware configuration. As a
result, the kernel will request a non-existent topology file.

Link: thesofproject/sof#6878
Fixes: 2ec8b08 ("ASoC: Intel: soc-acpi: Add entry for sof_es8336 in ADL match table")
Cc: stable@vger.kernel.org
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
@bardliao

Copy link
Copy Markdown
Collaborator

@plbossart There is another topology name with es83x6, do you want to change it, too?

	{
		.comp_ids = &essx_83x6,
		.drv_name = "adl_es83x6_c1_h02",
		.machine_quirk = snd_soc_acpi_codec_list,
		.quirk_data = &adl_lt6911_hdmi,
		.sof_tplg_filename = "sof-adl-es83x6-ssp1-hdmi-ssp02.tplg",
	},

@plbossart

Copy link
Copy Markdown
Member Author

@plbossart There is another topology name with es83x6, do you want to change it, too?

	{
		.comp_ids = &essx_83x6,
		.drv_name = "adl_es83x6_c1_h02",
		.machine_quirk = snd_soc_acpi_codec_list,
		.quirk_data = &adl_lt6911_hdmi,
		.sof_tplg_filename = "sof-adl-es83x6-ssp1-hdmi-ssp02.tplg",
	},

No, this is a different platform from Intel and they can fix it themselves. The point is that our esteemed colleagues mixed their own platform with the commercial ones.

@plbossart
plbossart merged commit d89aad2 into thesofproject:topic/sof-dev Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants