Repository navigation
Conversation
Collaborator
|
Can one of the admins verify this patch?
|
plbossart
requested changes
Dec 9, 2022
plbossart
left a comment
plbossart
left a comment
Member
There was a problem hiding this comment.
looks good but formatting/signoff required. Thanks!
eugenhu
force-pushed
the
topic/sof-dev
branch
2 times, most recently
from
January 2, 2023 16:16
3278594 to
e73bea3
Compare
eugenhu
marked this pull request as ready for review
January 2, 2023 16:20
eugenhu
requested review from
RanderWang,
ajitkupandey,
bardliao,
dbaluta,
jack-cy-yu,
kuanhsuncheng,
kv2019i,
lgirdwood,
oder-chiou,
ranj063,
ryans-lee,
shumingfan,
ujfalusi and
yaochunhung
as code owners
January 2, 2023 16:20
eugenhu
removed request for
RanderWang,
bardliao,
dbaluta,
jack-cy-yu,
lgirdwood,
oder-chiou,
ranj063,
ryans-lee,
shumingfan and
ujfalusi
January 2, 2023 16:21
eugenhu
requested review from
plbossart
and removed request for
ajitkupandey,
kuanhsuncheng,
kv2019i and
yaochunhung
January 2, 2023 16:21
bardliao
reviewed
Jan 3, 2023
Same DSDT problem as the HP Omen 16-k0005TX, except rt1316 amp is on link2. Link: thesofproject#4088 Signed-off-by: Eugene Huang <eugene.huang99@gmail.com>
Same quirks as the 'Bishop County' NUC M15, except the rt711 is in the 'JD2 100K' jack detection mode. Link: thesofproject#4088 Signed-off-by: Eugene Huang <eugene.huang99@gmail.com>
Same topology as the HP Omen 16-k0005TX, except with the rt1316 amp on link2. Link: thesofproject#4088 Signed-off-by: Eugene Huang <eugene.huang99@gmail.com>
bardliao
approved these changes
Jan 3, 2023
ujfalusi
approved these changes
Jan 3, 2023
Member
|
test this please |
plbossart
approved these changes
Jan 3, 2023
Member
|
SOFCI TEST |
Member
|
for some reason I can't merge this branch, GitHub tells me: Merge attempt failed yay 2023 |
Collaborator
|
SOFCI TEST |
Member
|
GitHub is still completely stupidly useless, trying with the same code in a different PR #4126 |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussed in #4088.